From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] runtest/fs: Don't read files in /dev indiscriminately
Date: Mon, 14 May 2018 10:53:24 +0200 [thread overview]
Message-ID: <20180514085324.GA20130@rei.lan> (raw)
In-Reply-To: <87lgcmy9uq.fsf@rpws.prws.suse.cz>
Hi!
> > It would be better to replace indiscriminate reading of /dev files
> > with tests targeting specific files in /dev which have defined known
> > behaviour, e.g., /dev/null, /dev/urandom, etc.
> >
> > In the meanwhile, drop the indiscriminate reading of files in /dev.
>
> Another solution might be to add an option which drops privileges before
> running the test on /dev. An unprivileged user should not have access to files
> like /dev/port, but will for /dev/null and /dev/urandom.
That sounds like a better solution to me, can we get that in before the
release?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-05-14 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 17:31 [LTP] [PATCH] runtest/fs: Don't read files in /dev indiscriminately Punit Agrawal
2018-05-14 7:28 ` Richard Palethorpe
2018-05-14 8:53 ` Cyril Hrubis [this message]
2018-05-14 9:04 ` Richard Palethorpe
2018-05-14 10:07 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514085324.GA20130@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox