public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/6] network/tcp_cc/lib: add a function to set qdisc and txqueuelen
Date: Mon, 28 May 2018 06:20:05 +0200	[thread overview]
Message-ID: <20180528042005.GA2147@x230> (raw)
In-Reply-To: <1526903310-2833-5-git-send-email-alexey.kodanev@oracle.com>

Hi Alexey,

> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
> ---
>  testcases/network/tcp_cc/tcp_cc_lib.sh |   34 ++++++++++++++++++++++++++++++++
>  1 files changed, 34 insertions(+), 0 deletions(-)

> diff --git a/testcases/network/tcp_cc/tcp_cc_lib.sh b/testcases/network/tcp_cc/tcp_cc_lib.sh
> index b96c8af..7e93e1d 100755
> --- a/testcases/network/tcp_cc/tcp_cc_lib.sh
> +++ b/testcases/network/tcp_cc/tcp_cc_lib.sh
> @@ -9,6 +9,8 @@ TST_NEEDS_CMDS="sysctl tc"
>  . tst_net.sh

>  def_alg="cubic"
> +prev_qlen=
> +prev_queue=
>  prev_alg=

>  set_cong_alg()
> @@ -21,8 +23,16 @@ set_cong_alg()

>  tcp_cc_cleanup()
>  {
> +	local rmt_dev="dev $(tst_iface rhost)"
> +
>  	[ "$prev_cong_ctl" ] && \
>  		tst_set_sysctl net.ipv4.tcp_congestion_control $prev_alg
> +
> +	[ "$prev_qlen" ] && \
> +		tst_rhost_run -c "ip li set txqueuelen $prev_qlen $rmt_dev"
> +
> +	[ "$prev_queue" ] && \
> +		tst_rhost_run -c "tc qdisc replace $rmt_dev root $prev_queue"
>  }

>  tcp_cc_setup()
> @@ -30,6 +40,30 @@ tcp_cc_setup()
>  	prev_alg="$(sysctl -n net.ipv4.tcp_congestion_control)"
>  }

> +qdisc_list="pfifo_fast codel pfifo fq hfsc hhf htb pie prio sfb sfq"
Maybe just one thing: wouldn't be better to have this upper case as it's
library variable shared in tests? But it's only a minor nit.


Kind regards,
Petr

  parent reply	other threads:[~2018-05-28  4:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 11:48 [LTP] [PATCH 0/6] network/tcp_cc: add new tests bbr01 and bbr02 Alexey Kodanev
2018-05-21 11:48 ` [LTP] [PATCH 1/6] network: rename dcctp dir to tcp_cc Alexey Kodanev
2018-05-28  4:11   ` Petr Vorel
2018-05-28  5:40   ` Petr Vorel
2018-05-21 11:48 ` [LTP] [PATCH 2/6] dctcp01: convert to new API and move common code to a library Alexey Kodanev
2018-05-28  5:42   ` Petr Vorel
2018-05-21 11:48 ` [LTP] [PATCH 3/6] network/tcp_cc/dctcp01: increase packet loss for dctcp Alexey Kodanev
2018-05-28  5:43   ` Petr Vorel
2018-05-21 11:48 ` [LTP] [PATCH 4/6] network/tcp_cc/lib: add a function to set qdisc and txqueuelen Alexey Kodanev
2018-05-28  4:15   ` Petr Vorel
2018-05-28  4:20   ` Petr Vorel [this message]
2018-05-28  5:44   ` Petr Vorel
2018-05-28  5:47     ` Petr Vorel
2018-05-21 11:48 ` [LTP] [PATCH 5/6] network/tcp_cc: add new test bbr01 Alexey Kodanev
2018-05-28  4:15   ` Petr Vorel
2018-05-28  5:44   ` Petr Vorel
2018-05-21 11:48 ` [LTP] [PATCH 6/6] network/tcp_cc: add new test bbr02 Alexey Kodanev
2018-05-28  4:21   ` Petr Vorel
2018-06-08 13:42     ` Alexey Kodanev
2018-06-08 14:00       ` Petr Vorel
2018-05-28  5:45   ` Petr Vorel
2018-05-24 15:41 ` [LTP] [PATCH 0/6] network/tcp_cc: add new tests bbr01 and bbr02 Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180528042005.GA2147@x230 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox