From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/4] tst_net.sh: Simplify ipver settings code
Date: Tue, 29 May 2018 09:59:48 +0200 [thread overview]
Message-ID: <20180529075948.GA10361@x230> (raw)
In-Reply-To: <2dad0d9c-ddfa-e6d2-2630-321d51545434@oracle.com>
Hi Alexey,
> On 05/26/2018 02:15 PM, Petr Vorel wrote:
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > testcases/lib/tst_net.sh | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> > diff --git a/testcases/lib/tst_net.sh b/testcases/lib/tst_net.sh
> > index dc612a794..fd2eacf2f 100644
> > --- a/testcases/lib/tst_net.sh
> > +++ b/testcases/lib/tst_net.sh
> > @@ -29,11 +29,12 @@ TST_SETUP="tst_net_setup"
> > # Blank for an IPV4 test; 6 for an IPV6 test.
> > TST_IPV6=${TST_IPV6:-}
> > +ipver=${TST_IPV6:-4}
> Hi Petr,
> Perhaps, we need a prefix TST_.
> Shouldn't the same patch remove the setting of 'ipver' in the tests?
Thanks for comments, both makes sense. I wanted to do it after migrating everything to new
API, but probably better to do it before.
> Thanks,
> Alexey
Kind regards,
Petr
prev parent reply other threads:[~2018-05-29 7:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-26 11:15 [LTP] [PATCH 1/4] tst_net.sh: Simplify ipver settings code Petr Vorel
2018-05-26 11:15 ` [LTP] [PATCH 2/4] net: Allow to overwrite libraries getopts handlers Petr Vorel
2018-05-28 13:48 ` Alexey Kodanev
2018-05-29 8:07 ` Petr Vorel
2018-05-26 11:15 ` [LTP] [PATCH 3/4] net: Allow to skip additional getopts Petr Vorel
2018-05-26 11:15 ` [LTP] [PATCH 4/4] net/macsec0{1, 2}.sh: Use TST_NET_SKIP_PARSE_ARGS=1 Petr Vorel
2018-05-28 14:03 ` Alexey Kodanev
2018-05-29 8:08 ` Petr Vorel
2018-05-28 13:31 ` [LTP] [PATCH 1/4] tst_net.sh: Simplify ipver settings code Alexey Kodanev
2018-05-29 7:59 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529075948.GA10361@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox