From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/4] net/macsec0{1, 2}.sh: Use TST_NET_SKIP_PARSE_ARGS=1
Date: Tue, 29 May 2018 10:08:55 +0200 [thread overview]
Message-ID: <20180529080855.GC10361@x230> (raw)
In-Reply-To: <e8c0ca78-e854-c160-f3c6-87241a259cfd@oracle.com>
Hi Alexey,
> On 05/26/2018 02:15 PM, Petr Vorel wrote:
> > These tests load ipsec_lib.sh and virt_lib.sh.
> > Currently tst_net.sh doesn't support being used by more libraries, so
> > when handling getopts the later one wins.
> > Disabling variables as they aren't used in the runtest file.
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > Alexey, do you use library variables for debugging?
> > Or would you prefer to be without this and to have at least one
> > libraries getopts?
> I'm for keeping the IPsec options in macsec test, some of them are not
> explicitly defined in the test, therefore can be changed.
OK, thanks for info.
> For virt_lib.sh library the better fix would be to define the options
> only for vxlan/geneve tests, because only those tests are currently
> using them.
Could you please make this change?
Kind regards,
Petr
next prev parent reply other threads:[~2018-05-29 8:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-26 11:15 [LTP] [PATCH 1/4] tst_net.sh: Simplify ipver settings code Petr Vorel
2018-05-26 11:15 ` [LTP] [PATCH 2/4] net: Allow to overwrite libraries getopts handlers Petr Vorel
2018-05-28 13:48 ` Alexey Kodanev
2018-05-29 8:07 ` Petr Vorel
2018-05-26 11:15 ` [LTP] [PATCH 3/4] net: Allow to skip additional getopts Petr Vorel
2018-05-26 11:15 ` [LTP] [PATCH 4/4] net/macsec0{1, 2}.sh: Use TST_NET_SKIP_PARSE_ARGS=1 Petr Vorel
2018-05-28 14:03 ` Alexey Kodanev
2018-05-29 8:08 ` Petr Vorel [this message]
2018-05-28 13:31 ` [LTP] [PATCH 1/4] tst_net.sh: Simplify ipver settings code Alexey Kodanev
2018-05-29 7:59 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529080855.GC10361@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox