From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Tue, 29 May 2018 10:08:55 +0200 Subject: [LTP] [PATCH 4/4] net/macsec0{1, 2}.sh: Use TST_NET_SKIP_PARSE_ARGS=1 In-Reply-To: References: <20180526111545.20521-1-pvorel@suse.cz> <20180526111545.20521-4-pvorel@suse.cz> Message-ID: <20180529080855.GC10361@x230> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Alexey, > On 05/26/2018 02:15 PM, Petr Vorel wrote: > > These tests load ipsec_lib.sh and virt_lib.sh. > > Currently tst_net.sh doesn't support being used by more libraries, so > > when handling getopts the later one wins. > > Disabling variables as they aren't used in the runtest file. > > Signed-off-by: Petr Vorel > > --- > > Alexey, do you use library variables for debugging? > > Or would you prefer to be without this and to have at least one > > libraries getopts? > I'm for keeping the IPsec options in macsec test, some of them are not > explicitly defined in the test, therefore can be changed. OK, thanks for info. > For virt_lib.sh library the better fix would be to define the options > only for vxlan/geneve tests, because only those tests are currently > using them. Could you please make this change? Kind regards, Petr