Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] LTP CVE "cve-2011-2183" failed on x86_64, arm32 beaglebone x15
Date: Mon, 4 Jun 2018 14:07:33 +0200	[thread overview]
Message-ID: <20180604120733.GC3362@rei> (raw)
In-Reply-To: <CA+G9fYuUAPvwBjXjw_EATrMoLPtS5imGo7foqchmAFD=TUdVXQ@mail.gmail.com>

Hi!
> LTP CVE "cve-2011-2183" failed on x86_64, (arm32) beaglebone x15.
> 
> Please check the history here,
> https://qa-reports.linaro.org/lkft/linux-mainline-oe/tests/ltp-cve-tests/cve-2011-2183
> 
> Test log:
> ----------
> tst_test.c:980: INFO: Timeout per run is 0h 15m 00s
> ksm05.c:98: CONF: KSM configuration is not enabled
> safe_file_ops.c:238: WARN: Failed to open FILE
> '/sys/kernel/mm/ksm/run' at ksm05.c:110

That is an obvious bug in the test, the value of run should be restored
only if we managed to change it.


We should do at least:

diff --git a/testcases/kernel/mem/ksm/ksm05.c b/testcases/kernel/mem/ksm/ksm05.c
index f3bfbf4fa..6deaa8440 100644
--- a/testcases/kernel/mem/ksm/ksm05.c
+++ b/testcases/kernel/mem/ksm/ksm05.c
@@ -107,7 +107,8 @@ static void setup(void)
 static void cleanup(void)
 {
        /* restore /sys/kernel/mm/ksm/run value */
-       FILE_PRINTF(PATH_KSM "run", "%d", ksm_run_orig);
+       if (!access(PATH_KSM, F_OK))
+               FILE_PRINTF(PATH_KSM "run", "%d", ksm_run_orig);
 }
 
 static struct tst_test test = {

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2018-06-04 12:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04 11:58 [LTP] LTP CVE "cve-2011-2183" failed on x86_64, arm32 beaglebone x15 Naresh Kamboju
2018-06-04 12:07 ` Cyril Hrubis [this message]
2018-06-04 12:32   ` Cyril Hrubis
2018-06-05 14:22     ` Naresh Kamboju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180604120733.GC3362@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox