Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH v6 3/5] tst_test.sh: Filter out commented out lines from warnings
Date: Tue, 5 Jun 2018 16:38:00 +0200	[thread overview]
Message-ID: <20180605143800.GA6190@rei> (raw)
In-Reply-To: <20180604213420.GA2783@x230>

Hi!
> > foo # run function foo
> Not sure what you expected. The behavior is:
> 
> * no warning for:
>   # _tst_foo run function _tst_foo
> 
> * warning for:
>   _tst_foo # run function _tst_foo

We will also get warning for:

tst_foo # we are not allowed to call _tst_foo

I was trying to point out that the solution is incomplete...

But anyway I see no point in proceeding further with the implemtation.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2018-06-05 14:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01  7:28 [LTP] [RFC PATCH v6 0/5] Add TST_TEST_DATA and TST_TEST_DATA_IFS + cleanup Petr Vorel
2018-06-01  7:28 ` [LTP] [RFC PATCH v6 1/5] tst_test.sh: Hide "private" variables with "_tst_" prefix Petr Vorel
2018-06-01  7:28 ` [LTP] [RFC PATCH v6 2/5] tst_test.sh: Warn about using "private" variable or function Petr Vorel
2018-06-01  7:28 ` [LTP] [RFC PATCH v6 3/5] tst_test.sh: Filter out commented out lines from warnings Petr Vorel
2018-06-04 21:06   ` Cyril Hrubis
2018-06-04 21:34     ` Petr Vorel
2018-06-05 14:38       ` Cyril Hrubis [this message]
2018-06-01  7:28 ` [LTP] [RFC PATCH v6 4/5] tst_test.sh: s/resm/res/ Petr Vorel
2018-06-01  7:28 ` [LTP] [RFC PATCH v6 5/5] tst_test.sh: Add TST_TEST_DATA and TST_TEST_DATA_IFS Petr Vorel
2018-06-05 15:09   ` Cyril Hrubis
2018-06-05 18:43     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180605143800.GA6190@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox