[LTP] [RFC PATCH 3/9] syscalls/ipc: Rewrite msgctl01 + merge msgctl06

Cyril Hrubis
2018-06-20T10:57:28Z

Hi!
> ???
> ???I'm thinking that whether 1 second is enough for system shaking. ???If this
> program is running on an overload system, this maybe delay more than 1
> second and test fails, is that a test defect????

Since we are calling just two subsequent syscalls here it's very
unlikely that the difference in times will be greater than 1s even on
loaded system, but for sure we can increase that to two or three that
wouldn't do any harm.

> Maybe gives more flexible as:
> if (buf.msg_ctime <= creat_time && buf.msg_ctime >= creat_time - 3)
>
>
> > + tst_res(TPASS, "msg_ctime = %lu, expected %lu",
> > + (unsigned long)buf.msg_ctime, (unsigned
> > long)creat_time);
> > + } else {
> > + tst_res(TPASS, "msg_ctime = %lu, expected %lu",
> >
>
> ???seems typo here? TFAIL

Right, thanks for pointing it out!

> > + (unsigned long)buf.msg_ctime, (unsigned
> > long)creat_time);
> > + }
>
>
> >
> ???Beside that, I got this follow errors occasionally:
>
> ???# ./msgctl01
> tst_test.c:1015: INFO: Timeout per run is 0h 05m 00s
> tst_safe_sysv_ipc.c:51: BROK: msgctl01.c:137: msgget(1627794347, 7b0)
> failed: EEXIST???

That means that there is some leftover message queue on the system,
there may be a problem in how the IDs are allocated in the IPC test
library.

Do you have any steps to reproduce the issue?

--
Cyril Hrubis
chrubis@suse.cz