public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 3/9] syscalls/ipc: Rewrite msgctl01 + merge msgctl06
Date: Wed, 20 Jun 2018 12:57:28 +0200	[thread overview]
Message-ID: <20180620105728.GB23700@rei> (raw)
In-Reply-To: <CAEemH2fmszUp0TMC24+kJuGYrBbwyrwe67B28AoWB16-MCj89A@mail.gmail.com>

Hi!
> ???
> ???I'm thinking that whether 1 second is enough for system shaking. ???If this
> program is running on an overload system, this maybe delay more than 1
> second and test fails, is that a test defect????

Since we are calling just two subsequent syscalls here it's very
unlikely that the difference in times will be greater than 1s even on
loaded system, but for sure we can increase that to two or three that
wouldn't do any harm.

> Maybe gives more flexible as:
>     if (buf.msg_ctime <= creat_time && buf.msg_ctime >= creat_time - 3)
> 
> 
> > +               tst_res(TPASS, "msg_ctime = %lu, expected %lu",
> > +                       (unsigned long)buf.msg_ctime, (unsigned
> > long)creat_time);
> > +       } else {
> > +               tst_res(TPASS, "msg_ctime = %lu, expected %lu",
> >
> 
> ???seems typo here?  TFAIL

Right, thanks for pointing it out!

> > +                       (unsigned long)buf.msg_ctime, (unsigned
> > long)creat_time);
> > +       }
> 
> 
> >
> ???Beside that, I got this follow errors occasionally:
> 
> ???# ./msgctl01
> tst_test.c:1015: INFO: Timeout per run is 0h 05m 00s
> tst_safe_sysv_ipc.c:51: BROK: msgctl01.c:137: msgget(1627794347, 7b0)
> failed: EEXIST???

That means that there is some leftover message queue on the system,
there may be a problem in how the IDs are allocated in the IPC test
library.

Do you have any steps to reproduce the issue?

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2018-06-20 10:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 15:46 [LTP] [RFC PATCH 0/9] Rewrite msgctl testcases Cyril Hrubis
2018-06-12 15:46 ` [LTP] [RFC PATCH 1/9] tst_safe_sysv_ipc: Make safe_shmctl() and safe_msgctl() safer Cyril Hrubis
2018-06-13 10:32   ` Petr Vorel
2018-06-12 15:46 ` [LTP] [RFC PATCH 2/9] tst_safe_sysv_ipc: SAFE_{SHMCTL, MSGCTL} return retval Cyril Hrubis
2018-06-13 10:49   ` Petr Vorel
2018-06-12 15:46 ` [LTP] [RFC PATCH 3/9] syscalls/ipc: Rewrite msgctl01 + merge msgctl06 Cyril Hrubis
2018-06-13  8:56   ` Li Wang
2018-06-20 10:57     ` Cyril Hrubis [this message]
2018-06-21  8:56       ` Li Wang
2018-06-13 11:24   ` Petr Vorel
2018-06-12 15:46 ` [LTP] [RFC PATCH 4/9] syscalls/ipc: Rewrite msgctl02 to new library Cyril Hrubis
2018-06-13 11:47   ` Petr Vorel
2018-06-12 15:46 ` [LTP] [RFC PATCH 5/9] syscalls/ipc: Convert to newlib and merge msgctl{13, 03} Cyril Hrubis
2018-06-13 11:55   ` Petr Vorel
2018-06-12 15:46 ` [LTP] [RFC PATCH 6/9] syscalls/ipc: Rewrite + merge msgctl{04, 05} Cyril Hrubis
2018-06-13 12:00   ` Petr Vorel
2018-06-12 15:46 ` [LTP] [RFC PATCH 7/9] syscalls/ipc: Rewrite msgctl12 to new library Cyril Hrubis
2018-06-13 12:12   ` Petr Vorel
2018-06-12 15:46 ` [LTP] [RFC PATCH 8/9] syscalls/ipc: Remove msgctl07 Cyril Hrubis
2018-06-13 12:28   ` Petr Vorel
2018-06-12 15:46 ` [LTP] [RFC PATCH 9/9] syscalls/ipc: Fix Makefile Cyril Hrubis
2018-06-13 12:35   ` Petr Vorel
2018-06-20 10:48     ` Cyril Hrubis
2018-06-20 15:26       ` Petr Vorel
2018-06-25 12:02 ` [LTP] [RFC PATCH 0/9] Rewrite msgctl testcases Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180620105728.GB23700@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox