From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 3/3] cve/cve-2018-1000001: Add Realpath Buffer Underflow test
Date: Thu, 21 Jun 2018 16:12:12 +0200 [thread overview]
Message-ID: <20180621141211.GA14165@rei> (raw)
In-Reply-To: <20180621141012.362aoktmiyfe5wjk@dell5510>
Hi!
> > I doubt that we need the cast to char* here.
>
> We do:
> getcwd05.c: In function ???run???:
> ../../../../include/tst_test.h:53:40: warning: format ???%s??? expects argument of type ???char *???, but argument 5 has type ???void *??? [-Wformat=]
> tst_res_(__FILE__, __LINE__, (ttype), (arg_fmt), ##__VA_ARGS__)
>
> So is something wrong in my TESTPTR() implementation?
Ah, okay my bad, so gcc is strict here (which makes sense).
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2018-06-21 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 15:48 [LTP] [PATCH v2 1/3] lib: Add SAFE_CHROOT(path) macro Petr Vorel
2018-06-20 15:48 ` [LTP] [PATCH v2 2/3] lib: Introduce TESTPTR() Petr Vorel
2018-06-20 15:48 ` [LTP] [PATCH v2 3/3] cve/cve-2018-1000001: Add Realpath Buffer Underflow test Petr Vorel
2018-06-21 9:34 ` Cyril Hrubis
2018-06-21 14:10 ` Petr Vorel
2018-06-21 14:12 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621141211.GA14165@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox