public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/shmctl05: new test for IPC file use-after-free bug
Date: Tue, 26 Jun 2018 13:35:47 +0200	[thread overview]
Message-ID: <20180626113547.GG24288@rei> (raw)
In-Reply-To: <20180518132536.GB32299@rei>

Hi!
> Have you considered using the fuzzy sync library here?
> 
> https://github.com/linux-test-project/ltp/blob/master/include/tst_fuzzy_sync.h

I've tried to rewrite the test so that it uses the fuzzy sync library to
synchronize the remap_file_page syscall againts the IPC_RMID but for
some reason that does not seem to trigger the issues for me, while the
original reproducer triggers it just fine. There must be some subtle
difference, maybe we need to train branch predictor with the loop that
calls the remap_file_pages, maybe it's something else.

So I guess that the best solution would be merging the testcase as it
is, however for me the test timeouts on broken kernel as the test
process just hangs there which produces misleading test error message.
Maybe we just need to add .timeout_is_failure flag to the test structure
for these kind of testcases so that the test library will hint the
tester that this timeout likely means that the kernel bug has been
reproduced.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2018-06-26 11:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-13  1:23 [LTP] [PATCH] syscalls/shmctl05: new test for IPC file use-after-free bug Eric Biggers
2018-05-18 13:25 ` Cyril Hrubis
2018-06-26 11:35   ` Cyril Hrubis [this message]
2018-06-27  6:18     ` Eric Biggers
2018-06-27 10:51       ` Cyril Hrubis
2018-06-27 13:59       ` Cyril Hrubis
2018-06-28  6:46         ` Eric Biggers
2018-06-28  9:00           ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180626113547.GG24288@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox