public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Punit Agrawal <punit.agrawal@arm.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] acl_test01: Add setfacl as an explicit dependency
Date: Fri,  6 Jul 2018 16:29:27 +0100	[thread overview]
Message-ID: <20180706152927.26646-1-punit.agrawal@arm.com> (raw)

acl_test01 calls setfacl during execution but does not explicitly
check for its presence during setup.

Add this dependency to correctly report the failure mode when setfacl
is not found.

Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
---
 testcases/kernel/fs/acls/acl_test01 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/kernel/fs/acls/acl_test01 b/testcases/kernel/fs/acls/acl_test01
index c91eb5686..14b62e895 100755
--- a/testcases/kernel/fs/acls/acl_test01
+++ b/testcases/kernel/fs/acls/acl_test01
@@ -64,6 +64,7 @@ fi
 do_setup()
 {
 	tst_require_root
+	tst_check_cmds setfacl
 
 	if ! ( test -d $TMP/tacl || mkdir -m 777 $TMP/tacl) ; then
 		tst_brkm TBROK "Failed to create $TMP/tacl directory."
-- 
2.17.1


             reply	other threads:[~2018-07-06 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 15:29 Punit Agrawal [this message]
2018-07-10 13:53 ` [LTP] [PATCH] acl_test01: Add setfacl as an explicit dependency Jan Stancek
2018-07-10 14:34   ` Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180706152927.26646-1-punit.agrawal@arm.com \
    --to=punit.agrawal@arm.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox