public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Punit Agrawal <punit.agrawal@arm.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/4] controllers/cgroup_fj_common.sh: Check for dependencies during setup
Date: Wed, 11 Jul 2018 13:29:22 +0100	[thread overview]
Message-ID: <20180711122925.24278-2-punit.agrawal@arm.com> (raw)
In-Reply-To: <20180711122925.24278-1-punit.agrawal@arm.com>

cgroup_fj_common.sh uses 'killall' in cleanup but doesn't check for it
during setup. Add killall as an explicit dependency to bail out on
systems where it's not available.

Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
---
 testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
index 907881ca8..e163e5394 100755
--- a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
+++ b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
@@ -83,6 +83,7 @@ create_subgroup()
 setup()
 {
     tst_require_root
+    tst_check_cmds killall
 
     if [ ! -f /proc/cgroups ]; then
         tst_brkm TCONF "Kernel does not support for control groups"
-- 
2.17.1


  reply	other threads:[~2018-07-11 12:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-11 12:29 [LTP] [PATCH 0/4] Add dependency checking Punit Agrawal
2018-07-11 12:29 ` Punit Agrawal [this message]
2018-07-11 12:29 ` [LTP] [PATCH 2/4] quota_remount_test01: Add explicit check for dependencies Punit Agrawal
2018-07-11 12:29 ` [LTP] [PATCH 3/4] memcg_lib.sh: Check for killall Punit Agrawal
2018-07-11 12:29 ` [LTP] [PATCH 4/4] controllers/pids.sh: " Punit Agrawal
2018-07-16 15:52 ` [LTP] [PATCH 0/4] Add dependency checking Jan Stancek
2018-07-16 16:20   ` Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180711122925.24278-2-punit.agrawal@arm.com \
    --to=punit.agrawal@arm.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox