From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/3] syscalls/alarm03: Rewrite to new library
Date: Wed, 25 Jul 2018 16:52:24 +0200 [thread overview]
Message-ID: <20180725145224.GD21960@rei> (raw)
In-Reply-To: <20180725142030.GC23890@rei>
Hi!
> > - tst_sig(FORK, DEF_HANDLER, cleanup);
> > -
> > - signal(SIGALRM, trapper);
> > -
> > - TEST_PAUSE;
> > + SAFE_SIGNAL(SIGALRM, sighandler);
>
> I do wonder why do we call the SAFE_SIGNAL() here?
>
> It does not make much sense.
Actually why we are even installing the signal handler, we do not wait
for the alarm to fire anyways.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-07-25 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 11:30 [LTP] [PATCH 1/3] syscalls/alarm02: Rewrite to new library Jinhui huang
2018-07-24 11:30 ` [LTP] [PATCH 2/3] syscalls/alarm03: " Jinhui huang
2018-07-25 14:20 ` Cyril Hrubis
2018-07-25 14:52 ` Cyril Hrubis [this message]
2018-07-24 11:30 ` [LTP] [PATCH 3/3] syscalls/alarm07: " Jinhui huang
2018-07-25 13:48 ` [LTP] [PATCH 1/3] syscalls/alarm02: " Cyril Hrubis
2018-07-26 5:32 ` [LTP] [PATCH v2 1/2] " Jinhui huang
2018-07-26 5:32 ` [LTP] [PATCH v2 2/2] syscalls/alarm03: " Jinhui huang
2018-08-02 15:54 ` [LTP] [PATCH v2 1/2] syscalls/alarm02: " Cyril Hrubis
2018-08-06 5:11 ` [LTP] [PATCH v3] " Jinhui huang
2018-08-07 9:16 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725145224.GD21960@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox