public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH RFC 1/4] lib/tst_test.c: add 'needs_drivers' option with tst_check_drivers cmd
Date: Tue, 14 Aug 2018 19:06:27 +0200	[thread overview]
Message-ID: <20180814170627.GA30905@dell5510> (raw)
In-Reply-To: <1533828226-24753-1-git-send-email-alexey.kodanev@oracle.com>

Hi Alexey,

> The drivers are checked with modprobe. If modrpobe is not available
                                            ^ typo modrpobe
> on the system, the checks are silently skipped.

> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
Acked-by: Petr Vorel <pvorel@suse.cz>

> ---
>  include/tst_test.h                |    5 +++++
>  lib/tst_test.c                    |   26 ++++++++++++++++++++++++++
>  testcases/lib/.gitignore          |    1 +
>  testcases/lib/Makefile            |    2 +-
>  testcases/lib/tst_check_drivers.c |   24 ++++++++++++++++++++++++
>  5 files changed, 57 insertions(+), 1 deletions(-)
>  create mode 100644 testcases/lib/tst_check_drivers.c

It'd be nice to add some docs into doc/test-writing-guidelines.txt.


Kind regards,
Petr

  parent reply	other threads:[~2018-08-14 17:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 15:23 [LTP] [PATCH RFC 1/4] lib/tst_test.c: add 'needs_drivers' option with tst_check_drivers cmd Alexey Kodanev
2018-08-09 15:23 ` [LTP] [PATCH RFC 2/4] lib/tst_test.sh: add TST_NEEDS_DRIVERS parameter Alexey Kodanev
2018-08-14 17:11   ` Petr Vorel
2018-08-16  8:54   ` Petr Vorel
2018-08-16 11:49     ` Alexey Kodanev
2018-08-09 15:23 ` [LTP] [PATCH RFC 3/4] lib/tst_test.sh: add TST_RTNL_CHK() helper function Alexey Kodanev
2018-08-14 18:39   ` Petr Vorel
2018-08-09 15:23 ` [LTP] [PATCH RFC 4/4] network/ipsec: replace ipsec_try() with TST_RTNL_CHK() Alexey Kodanev
2018-08-14 18:40   ` Petr Vorel
2018-08-16 11:16   ` [LTP] [RFC PATCH 2/2] netstress: Update help for -m behavior Petr Vorel
2018-08-16 12:01     ` Alexey Kodanev
2018-08-16 11:42   ` [LTP] [PATCH v2 1/1] network/route: Rewrite route-change-dst into new API Petr Vorel
2018-08-14 17:06 ` Petr Vorel [this message]
2018-08-15 15:22   ` [LTP] [PATCH RFC 1/4] lib/tst_test.c: add 'needs_drivers' option with tst_check_drivers cmd Alexey Kodanev
2018-08-16 10:59 ` Cyril Hrubis
2018-08-16 11:54   ` Alexey Kodanev
2018-08-16 11:53     ` Petr Vorel
2018-08-16 12:21       ` Alexey Kodanev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180814170627.GA30905@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox