From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Thu, 16 Aug 2018 13:53:47 +0200 Subject: [LTP] [PATCH RFC 1/4] lib/tst_test.c: add 'needs_drivers' option with tst_check_drivers cmd In-Reply-To: <1e9e35dc-3f2f-0eb7-59aa-8f600bdf949f@oracle.com> References: <1533828226-24753-1-git-send-email-alexey.kodanev@oracle.com> <20180816105934.GA4829@rei> <1e9e35dc-3f2f-0eb7-59aa-8f600bdf949f@oracle.com> Message-ID: <20180816115347.GC13716@dell5510> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi, > On 08/16/2018 01:59 PM, Cyril Hrubis wrote: > > Hi... > > I do not like much that we change the behavir based on tst_test content. > > Maybe it would be cleaner to define a tst_check_driver(const char *name), > > then we can do the loop over tst_test->needs_drivers in the tst_test.c > > library and loop over argv in the shell helper. +1 it makes sense. > Hi Cyril, > OK, will send the 2nd version. BTW it'd be nice to have support to load module with parameters. > Thanks, > Alexey Kind regards, Petr