From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/4] lib/tst_test.c: add .needs_devfs flag
Date: Thu, 16 Aug 2018 15:28:15 +0200 [thread overview]
Message-ID: <20180816132815.GB30369@rei> (raw)
In-Reply-To: <1534409147-29519-2-git-send-email-yangx.jy@cn.fujitsu.com>
Hi!
> We add .needs_devfs flag to prepare a suitable filesystem to test
> device special files and use ext2 instead of tmpfs(because tmpfs
> doesn't support extended attributes) as default filesystem if
> .dev_fs_type is not specified.
Can we do that only if the test temporary directory is not suitable for
creating devices?
There are distributions out there that have /tmp residing on pretty much
normal filesystems, also user can override TMPDIR to point to a path
backed up by a regular fs. In these cases this will slow down these
tests for no good reason.
So I would rather go for:
if tst_test->needs_devfs is set:
* mkdir tst_test->mntpoint if it does not exits
* check if tst_test->mntpoint is suitable for creating devices
* if not, mount some filesystem over it
- mounting tmpfs without nodev flag should be more than enough
and if that fails for you, we can fall back to a regular filesystem
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-08-16 13:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 8:00 [LTP] [PATCH] syscalls/open11.c: Fix the failure of opening device special file Xiao Yang
2018-07-23 1:42 ` Xiao Yang
2018-08-15 11:42 ` Cyril Hrubis
2018-08-16 8:45 ` [LTP] [PATCH v2 1/4] lib/tst_path_has_mnt_flags.c: Factor out tst_path_has_mnt_flags() for new API Xiao Yang
2018-08-16 8:45 ` [LTP] [PATCH v2 2/4] lib/tst_test.c: add .needs_devfs flag Xiao Yang
2018-08-16 13:28 ` Cyril Hrubis [this message]
2018-08-17 4:26 ` Xiao Yang
2018-08-17 4:33 ` [LTP] [PATCH v3 2/2] lib/tst_test.c: Add " Xiao Yang
2018-08-30 14:49 ` Cyril Hrubis
2018-08-31 2:58 ` Xiao Yang
2018-09-01 4:07 ` [LTP] [PATCH v4 " Xiao Yang
2018-08-31 12:31 ` Cyril Hrubis
2018-09-03 2:14 ` Xiao Yang
2018-09-03 13:01 ` Cyril Hrubis
2018-08-16 8:45 ` [LTP] [PATCH v2 3/4] syscalls/open11.c: Fix the failure of opening device special files Xiao Yang
2018-08-16 8:45 ` [LTP] [PATCH v2 4/4] syscalls/fsetxattr02.c: Fix the failure of opening device files Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816132815.GB30369@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox