From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v5] Testing statx syscall
Date: Mon, 20 Aug 2018 11:12:55 +0200 [thread overview]
Message-ID: <20180820091255.GA20974@dell5510> (raw)
In-Reply-To: <20180820083629.GB14682@dell5510>
Hi,
> > +AC_CHECK_FUNCS(statx,,)
> > +])
> > +AC_CHECK_MEMBERS([struct statx.stx_mask, struct statx.stx_blksize, struct statx.stx_attributes, struct statx.stx_nlink, struct statx.stx_uid, struct statx.stx_gid, struct statx.stx_mode, struct statx.stx_ino, struct statx.stx_size, struct statx.stx_blocks, struct statx.stx_attributes_mask, struct statx.stx_rdev_minor, struct statx.stx_mtime, struct statx.stx_atime, struct statx.stx_btime, struct statx.stx_ctime, struct statx.stx_rdev_major, struct statx.stx_dev_major, struct statx.stx_dev_minor])
> > +
> > +AC_CHECK_MEMBERS([struct statx_timestamp tv_sec, struct statx_timestamp tv_nsec])
> There is error in definition (end of function before AC_CHECK_MEMBERS calls +
> missing dot in second AC_CHECK_MEMBERS). Diff with fixes:
> diff --git a/configure.ac b/configure.ac
> index df64ce2e2..e1ecb32a7 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -200,6 +200,7 @@ LTP_CHECK_OPENAT
> LTP_CHECK_EXECVEAT
> LTP_CHECK_RENAMEAT
> LTP_CHECK_RENAMEAT2
> +LTP_CHECK_STATX
> LTP_CHECK_FALLOCATE
> LTP_CHECK_SYSCALL_FCNTL
> LTP_CHECK_SYSCALL_PERF_EVENT_OPEN
> diff --git a/m4/ltp-statx.m4 b/m4/ltp-statx.m4
> index 547172ebc..dec161567 100644
> --- a/m4/ltp-statx.m4
> +++ b/m4/ltp-statx.m4
> @@ -22,7 +22,7 @@ dnl ----------------------------
> dnl
> AC_DEFUN([LTP_CHECK_STATX],[
> AC_CHECK_FUNCS(statx,,)
> -])
> AC_CHECK_MEMBERS([struct statx.stx_mask, struct statx.stx_blksize, struct statx.stx_attributes, struct statx.stx_nlink, struct statx.stx_uid, struct statx.stx_gid, struct statx.stx_mode, struct statx.stx_ino, struct statx.stx_size, struct statx.stx_blocks, struct statx.stx_attributes_mask, struct statx.stx_rdev_minor, struct statx.stx_mtime, struct statx.stx_atime, struct statx.stx_btime, struct statx.stx_ctime, struct statx.stx_rdev_major, struct statx.stx_dev_major, struct statx.stx_dev_minor])
> -AC_CHECK_MEMBERS([struct statx_timestamp tv_sec, struct statx_timestamp tv_nsec])
> +AC_CHECK_MEMBERS([struct statx_timestamp.tv_sec, struct statx_timestamp.tv_nsec])
> +])
Actually, #include <linux/stat.h> is required for AC_CHECK_MEMBERS:
AC_CHECK_MEMBERS([struct statx.stx_mask, struct statx.stx_blksize, struct statx.stx_attributes, struct statx.stx_nlink, struct statx.stx_uid, struct statx.stx_gid, struct statx.stx_mode, struct statx.stx_ino, struct statx.stx_size, struct statx.stx_blocks, struct statx.stx_attributes_mask, struct statx.stx_rdev_minor, struct statx.stx_mtime, struct statx.stx_atime, struct statx.stx_btime, struct statx.stx_ctime, struct statx.stx_rdev_major, struct statx.stx_dev_major, struct statx.stx_dev_minor],,, [[#include <linux/stat.h>]])
AC_CHECK_MEMBERS([struct statx_timestamp.tv_sec, struct statx_timestamp.tv_nsec],,, [[#include <linux/stat.h>]])
+])
BTW: not sure if all struct members need to be checked for.
Kind regards,
Petr
prev parent reply other threads:[~2018-08-20 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 5:57 [LTP] [PATCH v5] Testing statx syscall vaishnavi.d
2018-08-17 7:28 ` Petr Vorel
2018-08-17 10:00 ` vaishnavi.d
2018-08-20 8:36 ` Petr Vorel
2018-08-20 9:12 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820091255.GA20974@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox