public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] open_posix_testsuite/mmap_11-4: Skip this test on tmpfs
Date: Tue, 28 Aug 2018 00:48:47 +0200	[thread overview]
Message-ID: <20180827224847.GA8057@dell5510> (raw)
In-Reply-To: <1533102620-30244-1-git-send-email-yangx.jy@cn.fujitsu.com>

Hi Xiao,
> According to mmap(2) manpage, when you write data to such partial
> page after the end of the object, the data stays in the page cache
> even after the file is closed and unmapped, subsequent mappings
> always see the modified content on tmpfs.  We just skip this test
> when running it on tmpfs.

> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>

> ---
>  .../conformance/interfaces/mmap/11-4.c                    | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)

> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/mmap/11-4.c b/testcases/open_posix_testsuite/conformance/interfaces/mmap/11-4.c
> index 2b44815..a52b288 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/mmap/11-4.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/mmap/11-4.c
> @@ -40,8 +40,11 @@
>  #include <fcntl.h>
>  #include <string.h>
>  #include <errno.h>
> +#include <sys/vfs.h>
>  #include "posixtest.h"

> +#define TYPE_TMPFS_MAGIC	0x01021994

Thanks for your patch, pushed.

I don't like redefinition of TMPFS_MAGIC, but I didn't change it as openposix
subproject don't use include directory from root and therefore we can't use
TST_TMPFS_MAGIC from tst_fs.h. And I didn't add include of <linux/magic.h>
due the same inaccessibility of config.h.
Maybe it'd make sense to make access for some of the headers from include
directory.


Kind regards,
Petr

      reply	other threads:[~2018-08-27 22:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01  5:50 [LTP] [PATCH] open_posix_testsuite/mmap_11-4: Skip this test on tmpfs Xiao Yang
2018-08-27 22:48 ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180827224847.GA8057@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox