public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [Query] With THP  numa01 - test5() fails
Date: Fri, 31 Aug 2018 12:30:44 +0200	[thread overview]
Message-ID: <20180831103044.GE16417@rei.lan> (raw)
In-Reply-To: <88657699-0FEF-45B4-84FC-9517A099F0B0@caviumnetworks.com>

Hi!
> >> While running LTP test suite with 4.18 kernel ( arm64 ).
> >> I see the below failure with THP (Transparent Hugepages) enabled.
> >> test5 -  Verification of shared memory interleaved on all nodes
> >> 
> >> numa01 1 TINFO: The system contains 2 nodes: 0 1
> >> numa01 1 TPASS: NUMA local node and memory affinity
> >> numa01 2 TPASS: NUMA preferred node policy
> >> numa01 3 TPASS: NUMA share memory allocated in preferred node
> >> numa01 4 TPASS: NUMA interleave policy
> >> numa01 5 TFAIL: NUMA interleave share memory allocated in node1 is less than expected
> > 
> > There are some problems with the test5. It also fails frequenty if /tmp
> > is on btrfs, the problem here is that file based mappings that are
> > (faulted) allocated by the filesystem driver do not tend to be
> > distributed fully evenly for various reasons (e.g. metadata blocks are
> > allocated in batches on btrfs).
> > 
> > So my guess here would be that THP causes some part(s) of the file, be
> > it metadata or the actuall data, backed up by a transparent huge page,
> > which causes the pages to be distributed unevely.
> > 
> > The solution is to take more than one sample and see if data are
> > distributed more or less evenly over sum of the samples,
> 
> The test randomly passes/fails. I am not sure if THP is related or not.
> I see test passing without adding any code with

That is another problem with the testcase my new tests fix, the old test
only takes into an account the sum of memory allcated on a node, so
depending on where the rest of the unrelated memory was allocated on it
can pass/fail randomly.

> linux-lr84:/opt/ltp # cat /sys/kernel/mm/transparent_hugepage/enabled
> [always] madvise never
> 
> > which is what
> > I'm working on in replacement for this test that would fix this problem
> > along with a few more, see:
> > 
> > http://lists.linux.it/pipermail/ltp/2018-August/009109.html
> > 
> > Can try the tests from that patchset to see if these are working fine
> > for you?
> 
> Getting errors with this patch.
> 
> ../../../../lib/libltp.a(tst_numa.o): In function `tst_numa_alloc_parse':
> /root/ltp/lib/tst_numa.c:78: undefined reference to `get_mempolicy'
> ../../../../lib/libltp.a(tst_numa.o): In function `tst_get_nodemap':
> /root/ltp/lib/tst_numa.c:108: undefined reference to `numa_get_membind'
> /root/ltp/lib/tst_numa.c:133: undefined reference to `numa_bitmask_free'
> /root/ltp/lib/tst_numa.c:112: undefined reference to `numa_bitmask_isbitset'
> /root/ltp/lib/tst_numa.c:127: undefined reference to `numa_bitmask_isbitset'
> /root/ltp/lib/tst_numa.c:108: undefined reference to `numa_get_membind'
> collect2: error: ld returned 1 exit status

You need libnuma devel packages installed to compile the code.

-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2018-08-31 10:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-30 11:34 [LTP] [Query] With THP numa01 - test5() fails Jaggi, Manish
2018-08-30 13:21 ` Cyril Hrubis
2018-08-31 10:27   ` Jaggi, Manish
2018-08-31 10:30     ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180831103044.GE16417@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox