* [LTP] [PATCH] runltp: change the default cmdfile to exec when exec runltp -N
@ 2018-09-04 0:58 Xiao Yang
2018-09-03 10:33 ` Petr Vorel
2018-09-04 0:58 ` [LTP] [PATCH] change the default command file of network Xiao Yang
0 siblings, 2 replies; 5+ messages in thread
From: Xiao Yang @ 2018-09-04 0:58 UTC (permalink / raw)
To: ltp
From: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
when exec "runltp -N" and no command files were provided, the
command file of "$LTPROOT/scenario_groups/network" should execute,
not the "$LTPROOT/scenario_groups/default".
Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
---
runltp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/runltp b/runltp
index 24ea94fe5..1810c9384 100755
--- a/runltp
+++ b/runltp
@@ -609,7 +609,7 @@ main()
SCENARIO_LISTS="$LTPROOT/scenario_groups/default"
if [ "$RUN_NETEST" -eq 1 ]; then
- SCENARIO_LISTS="$SCENARIO_LISTS $LTPROOT/scenario_groups/network"
+ SCENARIO_LISTS="$LTPROOT/scenario_groups/network"
fi
# DO NOT INDENT/DEDENT!
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [LTP] [PATCH] runltp: change the default cmdfile to exec when exec runltp -N
2018-09-04 0:58 [LTP] [PATCH] runltp: change the default cmdfile to exec when exec runltp -N Xiao Yang
@ 2018-09-03 10:33 ` Petr Vorel
2018-09-04 0:58 ` [LTP] [PATCH] change the default command file of network Xiao Yang
1 sibling, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2018-09-03 10:33 UTC (permalink / raw)
To: ltp
Hi Sun,
> From: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
> when exec "runltp -N" and no command files were provided, the
> command file of "$LTPROOT/scenario_groups/network" should execute,
> not the "$LTPROOT/scenario_groups/default".
> Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
> ---
> runltp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/runltp b/runltp
> index 24ea94fe5..1810c9384 100755
> --- a/runltp
> +++ b/runltp
> @@ -609,7 +609,7 @@ main()
> SCENARIO_LISTS="$LTPROOT/scenario_groups/default"
> if [ "$RUN_NETEST" -eq 1 ]; then
> - SCENARIO_LISTS="$SCENARIO_LISTS $LTPROOT/scenario_groups/network"
> + SCENARIO_LISTS="$LTPROOT/scenario_groups/network"
> fi
> # DO NOT INDENT/DEDENT!
Applied, thanks!
Using network.sh is the preferred way for running networking tests.
FYI runltp is somehow broken, we have long term goal to replace it with some
modern tool.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH] change the default command file of network
2018-09-04 0:58 [LTP] [PATCH] runltp: change the default cmdfile to exec when exec runltp -N Xiao Yang
2018-09-03 10:33 ` Petr Vorel
@ 2018-09-04 0:58 ` Xiao Yang
2018-09-03 9:40 ` Petr Vorel
1 sibling, 1 reply; 5+ messages in thread
From: Xiao Yang @ 2018-09-04 0:58 UTC (permalink / raw)
To: ltp
From: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
The options -N of runltp means "Run all the networking tests", and when
exec runltp -N and no command files were provied, the cmmand file of
"$LTPROOT/scenario_groups/network" should execute, so the the "$LTPROOT/
scenario_groups/network" should include the all the networking tests.
Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
---
scenario_groups/network | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/scenario_groups/network b/scenario_groups/network
index bf857b09e..d447daf88 100644
--- a/scenario_groups/network
+++ b/scenario_groups/network
@@ -1,4 +1,22 @@
+can
+net.features
+net.ipv6
+net.ipv6_lib
net.tcp_cmds
net.multicast
net.rpc
net.nfs
+net.rpc_tests
+net.tirpc_tests
+net.sctp
+network_commands
+net_stress.appl
+net_stress.broken_ip
+net_stress.interface
+net_stress.ipsec_dccp
+net_stress.ipsec_icmp
+net_stress.ipsec_sctp
+net_stress.ipsec_tcp
+net_stress.ipsec_udp
+net_stress.multicast
+net_stress.route
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [LTP] [PATCH] change the default command file of network
2018-09-04 0:58 ` [LTP] [PATCH] change the default command file of network Xiao Yang
@ 2018-09-03 9:40 ` Petr Vorel
2018-09-24 6:58 ` Petr Vorel
0 siblings, 1 reply; 5+ messages in thread
From: Petr Vorel @ 2018-09-03 9:40 UTC (permalink / raw)
To: ltp
Hi Sun,
> From: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
> The options -N of runltp means "Run all the networking tests", and when
> exec runltp -N and no command files were provied, the cmmand file of
> "$LTPROOT/scenario_groups/network" should execute, so the the "$LTPROOT/
> scenario_groups/network" should include the all the networking tests.
> Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
Acked-by: Petr Vorel <pvorel@suse.cz>
> ---
> scenario_groups/network | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> diff --git a/scenario_groups/network b/scenario_groups/network
> index bf857b09e..d447daf88 100644
> --- a/scenario_groups/network
> +++ b/scenario_groups/network
> @@ -1,4 +1,22 @@
> +can
> +net.features
> +net.ipv6
> +net.ipv6_lib
> net.tcp_cmds
> net.multicast
> net.rpc
> net.nfs
> +net.rpc_tests
> +net.tirpc_tests
> +net.sctp
> +network_commands
> +net_stress.appl
> +net_stress.broken_ip
> +net_stress.interface
> +net_stress.ipsec_dccp
> +net_stress.ipsec_icmp
> +net_stress.ipsec_sctp
> +net_stress.ipsec_tcp
> +net_stress.ipsec_udp
> +net_stress.multicast
> +net_stress.route
Although, network.sh is preferred way to run network tests.
+ net_stress.multicast and net_stress.route needs remove dependency on rsh,
so it's a question whether add them now.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH] change the default command file of network
2018-09-03 9:40 ` Petr Vorel
@ 2018-09-24 6:58 ` Petr Vorel
0 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2018-09-24 6:58 UTC (permalink / raw)
To: ltp
Hi Sun,
> > From: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
> > The options -N of runltp means "Run all the networking tests", and when
> > exec runltp -N and no command files were provied, the cmmand file of
> > "$LTPROOT/scenario_groups/network" should execute, so the the "$LTPROOT/
> > scenario_groups/network" should include the all the networking tests.
> > Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
> Acked-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > scenario_groups/network | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
...
> Although, network.sh is preferred way to run network tests.
> + net_stress.multicast and net_stress.route needs remove dependency on rsh,
> so it's a question whether add them now.
Pushed (with net_stress.multicast and net_stress.route).
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-24 6:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-04 0:58 [LTP] [PATCH] runltp: change the default cmdfile to exec when exec runltp -N Xiao Yang
2018-09-03 10:33 ` Petr Vorel
2018-09-04 0:58 ` [LTP] [PATCH] change the default command file of network Xiao Yang
2018-09-03 9:40 ` Petr Vorel
2018-09-24 6:58 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox