From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v7 1/4] Testing statx syscall
Date: Tue, 4 Sep 2018 14:40:32 +0200 [thread overview]
Message-ID: <20180904124032.GA5625@rei> (raw)
In-Reply-To: <20180903121631.3652-1-vaishnavi.d@zilogic.com>
Hi!
I've further split this patch into one that adds the configure checks
and fallback headers and another that adds the first test.
And also did following adjustements:
* The right configure check for structure existence is AC_CHECK_TYPES()
Also things break badly if you check for the structure in the
linux/stat.h but include sys/stat.h in the lapi fallback header, so we
have to check for the sys/stat.h in the configure check as well.
* The statx() wrapper has to use tst_syscall() so that you get correct
response when the syscall number is not defined on the system or in
the fallback file
* Removed the full GPLv2 from the lapi headers, it's not needed when the
SPDX identifier has been added, also since that is a machine readable
string it has to be exactly SPDX-License-Identifier: GPL-2.0-or-later
And for the statx01:
* Added the newly added .needs_defs flag so that the test works fine on
systems with /tmp mounted with nodev
* Changed the test to close the fd in the test setup, there is no reason
to keep it open until cleanup
* Changed the SAFE_WRITE(0, ...) to SAFE_WRITE(1, ...) since we need to
make sure the whole buffer has been written prior the test
* Remove the word "obtained" from the test messages as it was only
making the messages unnecessarily longer
* The check for stx_block was bogus, after thinking about it we create
file that contains 256 bytes so the number of blocks has to be
reasonably small number. Btrfs tends to allocate page_size blocks,
which means that the reported size there would be 128 which I suppose
is good enough upper bound. So we now check that the reported number
of blocks is > 0 and <= 128, which I guess is the best without
dwelling into filesystem details.
* Removed the full GPLv2 from the lapi headers, it's not needed when the
SPDX identifier has been added, also since that is a machine readable
string it has to be exactly SPDX-License-Identifier: GPL-2.0-or-later
And pushed the resulting two patches, thanks!
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2018-09-04 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 12:16 [LTP] [PATCH v7 1/4] Testing statx syscall Vaishnavi D
2018-09-04 12:40 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904124032.GA5625@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox