From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/4] lib/tst_test.sh: add TST_NEEDS_DRIVERS parameter
Date: Thu, 13 Sep 2018 14:35:01 +0200 [thread overview]
Message-ID: <20180913123501.GC18036@rei.lan> (raw)
In-Reply-To: <1534764229-26993-2-git-send-email-alexey.kodanev@oracle.com>
Hi!
> +tst_test_drivers()
> +{
> + [ $# -eq 0 ] && return 0
> +
> + local drv="$(tst_check_drivers $@ 2>&1)"
Wouldn't it be easier to just redirect the stderr into /dev/null here
and check the $? instead of [ -n "$drv" ] ?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-09-13 12:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 11:23 [LTP] [PATCH v2 1/4] lib/tst_test.c: add 'needs_drivers' option with tst_check_drivers cmd Alexey Kodanev
2018-08-20 11:23 ` [LTP] [PATCH v2 2/4] lib/tst_test.sh: add TST_NEEDS_DRIVERS parameter Alexey Kodanev
2018-08-22 15:42 ` Petr Vorel
2018-09-13 12:35 ` Cyril Hrubis [this message]
2018-09-14 11:54 ` Alexey Kodanev
2018-08-20 11:23 ` [LTP] [PATCH v2 3/4] lib/tst_test.sh: add TST_RTNL_CHK() helper function Alexey Kodanev
2018-09-13 13:00 ` Petr Vorel
2018-08-20 11:23 ` [LTP] [PATCH v2 4/4] network/ipsec: replace ipsec_try() with TST_RTNL_CHK() Alexey Kodanev
2018-08-22 15:45 ` Petr Vorel
2018-09-13 13:02 ` Petr Vorel
2018-08-22 15:41 ` [LTP] [PATCH v2 1/4] lib/tst_test.c: add 'needs_drivers' option with tst_check_drivers cmd Petr Vorel
2018-08-27 10:44 ` Alexey Kodanev
2018-09-06 17:53 ` Petr Vorel
2018-09-13 12:27 ` Cyril Hrubis
2018-09-14 11:41 ` Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913123501.GC18036@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox