* [LTP] [PATCH] hotplug/cpu_hotplug05.sh: Fix obsolete output of offline CPU
@ 2018-07-18 7:33 Xiao Yang
2018-09-13 7:41 ` Xiao Yang
2018-10-02 11:32 ` Cyril Hrubis
0 siblings, 2 replies; 5+ messages in thread
From: Xiao Yang @ 2018-07-18 7:33 UTC (permalink / raw)
To: ltp
With sysstat-11.7.1, running cpu_hotplug05.sh got the following error:
---------------------------------------------------------------------
cpuhotplug05 1 TBROK: Field 3 is '%user', '0.00' expected
---------------------------------------------------------------------
According to commit 970cae1 and 1f71a6f, sar/sadf didn't display offline
CPU since sysstat-11.7.1. It is reasonable for offline CPU to get nothing.
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
.../hotplug/cpu_hotplug/functional/cpuhotplug05.sh | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
index 59c8324..ab81684 100755
--- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
+++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
@@ -108,12 +108,18 @@ until [ $LOOP_COUNT -gt $HOTPLUG05_LOOPS ]; do
tst_brkm TBROK "SAR output file is empty"
fi
- for i in $(seq 3 8); do
- field=$(get_field "$offline_status" "$i")
- if [ "$field" != "0.00" ]; then
- tst_brkm TBROK "Field $i is '$field', '0.00' expected"
- fi
- done
+ cpu_field=$(get_field "$offline_status" "2")
+ if [ "${cpu_field}" = "CPU" ]; then
+ # Since sysstat-11.7.1, sar/sadf didn't display offline CPU
+ tst_resm TINFO "SAR didn't display offline CPU"
+ else
+ for i in $(seq 3 8); do
+ field=$(get_field "$offline_status" "$i")
+ if [ "$field" != "0.00" ]; then
+ tst_brkm TBROK "Field $i is '$field', '0.00' expected"
+ fi
+ done
+ fi
# Online the CPU
if ! online_cpu ${CPU_TO_TEST}; then
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [LTP] [PATCH] hotplug/cpu_hotplug05.sh: Fix obsolete output of offline CPU
2018-07-18 7:33 [LTP] [PATCH] hotplug/cpu_hotplug05.sh: Fix obsolete output of offline CPU Xiao Yang
@ 2018-09-13 7:41 ` Xiao Yang
2018-10-02 11:32 ` Cyril Hrubis
1 sibling, 0 replies; 5+ messages in thread
From: Xiao Yang @ 2018-09-13 7:41 UTC (permalink / raw)
To: ltp
Hi,
Ping :-)
Thanks,
Xiao Yang
On 2018/07/18 15:33, Xiao Yang wrote:
> With sysstat-11.7.1, running cpu_hotplug05.sh got the following error:
> ---------------------------------------------------------------------
> cpuhotplug05 1 TBROK: Field 3 is '%user', '0.00' expected
> ---------------------------------------------------------------------
>
> According to commit 970cae1 and 1f71a6f, sar/sadf didn't display offline
> CPU since sysstat-11.7.1. It is reasonable for offline CPU to get nothing.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
> .../hotplug/cpu_hotplug/functional/cpuhotplug05.sh | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> index 59c8324..ab81684 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> @@ -108,12 +108,18 @@ until [ $LOOP_COUNT -gt $HOTPLUG05_LOOPS ]; do
> tst_brkm TBROK "SAR output file is empty"
> fi
>
> - for i in $(seq 3 8); do
> - field=$(get_field "$offline_status" "$i")
> - if [ "$field" != "0.00" ]; then
> - tst_brkm TBROK "Field $i is '$field', '0.00' expected"
> - fi
> - done
> + cpu_field=$(get_field "$offline_status" "2")
> + if [ "${cpu_field}" = "CPU" ]; then
> + # Since sysstat-11.7.1, sar/sadf didn't display offline CPU
> + tst_resm TINFO "SAR didn't display offline CPU"
> + else
> + for i in $(seq 3 8); do
> + field=$(get_field "$offline_status" "$i")
> + if [ "$field" != "0.00" ]; then
> + tst_brkm TBROK "Field $i is '$field', '0.00' expected"
> + fi
> + done
> + fi
>
> # Online the CPU
> if ! online_cpu ${CPU_TO_TEST}; then
^ permalink raw reply [flat|nested] 5+ messages in thread* [LTP] [PATCH] hotplug/cpu_hotplug05.sh: Fix obsolete output of offline CPU
2018-07-18 7:33 [LTP] [PATCH] hotplug/cpu_hotplug05.sh: Fix obsolete output of offline CPU Xiao Yang
2018-09-13 7:41 ` Xiao Yang
@ 2018-10-02 11:32 ` Cyril Hrubis
1 sibling, 0 replies; 5+ messages in thread
From: Cyril Hrubis @ 2018-10-02 11:32 UTC (permalink / raw)
To: ltp
Hi!
Pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH] hotplug/cpu_hotplug05.sh: Fix obsolete output of offline CPU
@ 2018-07-18 7:28 Xiao Yang
2018-07-18 7:10 ` Xiao Yang
0 siblings, 1 reply; 5+ messages in thread
From: Xiao Yang @ 2018-07-18 7:28 UTC (permalink / raw)
To: ltp
With sysstat-11.7.1, running cpu_hotplug05.sh got the following error:
---------------------------------------------------------------------
cpuhotplug05 1 TBROK: Field 3 is '%user', '0.00' expected
---------------------------------------------------------------------
According to commit 970cae1 and 1f71a6f, sar/sadf didn't display offline
CPU since sysstat-11.7.1. It is reasonable for offline CPU to getting
nothing.
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
.../hotplug/cpu_hotplug/functional/cpuhotplug05.sh | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
index 59c8324..ab81684 100755
--- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
+++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
@@ -108,12 +108,18 @@ until [ $LOOP_COUNT -gt $HOTPLUG05_LOOPS ]; do
tst_brkm TBROK "SAR output file is empty"
fi
- for i in $(seq 3 8); do
- field=$(get_field "$offline_status" "$i")
- if [ "$field" != "0.00" ]; then
- tst_brkm TBROK "Field $i is '$field', '0.00' expected"
- fi
- done
+ cpu_field=$(get_field "$offline_status" "2")
+ if [ "${cpu_field}" = "CPU" ]; then
+ # Since sysstat-11.7.1, sar/sadf didn't display offline CPU
+ tst_resm TINFO "SAR didn't display offline CPU"
+ else
+ for i in $(seq 3 8); do
+ field=$(get_field "$offline_status" "$i")
+ if [ "$field" != "0.00" ]; then
+ tst_brkm TBROK "Field $i is '$field', '0.00' expected"
+ fi
+ done
+ fi
# Online the CPU
if ! online_cpu ${CPU_TO_TEST}; then
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [LTP] [PATCH] hotplug/cpu_hotplug05.sh: Fix obsolete output of offline CPU
2018-07-18 7:28 Xiao Yang
@ 2018-07-18 7:10 ` Xiao Yang
0 siblings, 0 replies; 5+ messages in thread
From: Xiao Yang @ 2018-07-18 7:10 UTC (permalink / raw)
To: ltp
Hi,
Sorry, some typos in this patch, and i will resend it. :-(
Thanks,
Xiao Yang
On 2018/07/18 15:28, Xiao Yang wrote:
> With sysstat-11.7.1, running cpu_hotplug05.sh got the following error:
> ---------------------------------------------------------------------
> cpuhotplug05 1 TBROK: Field 3 is '%user', '0.00' expected
> ---------------------------------------------------------------------
>
> According to commit 970cae1 and 1f71a6f, sar/sadf didn't display offline
> CPU since sysstat-11.7.1. It is reasonable for offline CPU to getting
> nothing.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
> .../hotplug/cpu_hotplug/functional/cpuhotplug05.sh | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> index 59c8324..ab81684 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> @@ -108,12 +108,18 @@ until [ $LOOP_COUNT -gt $HOTPLUG05_LOOPS ]; do
> tst_brkm TBROK "SAR output file is empty"
> fi
>
> - for i in $(seq 3 8); do
> - field=$(get_field "$offline_status" "$i")
> - if [ "$field" != "0.00" ]; then
> - tst_brkm TBROK "Field $i is '$field', '0.00' expected"
> - fi
> - done
> + cpu_field=$(get_field "$offline_status" "2")
> + if [ "${cpu_field}" = "CPU" ]; then
> + # Since sysstat-11.7.1, sar/sadf didn't display offline CPU
> + tst_resm TINFO "SAR didn't display offline CPU"
> + else
> + for i in $(seq 3 8); do
> + field=$(get_field "$offline_status" "$i")
> + if [ "$field" != "0.00" ]; then
> + tst_brkm TBROK "Field $i is '$field', '0.00' expected"
> + fi
> + done
> + fi
>
> # Online the CPU
> if ! online_cpu ${CPU_TO_TEST}; then
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-02 11:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-18 7:33 [LTP] [PATCH] hotplug/cpu_hotplug05.sh: Fix obsolete output of offline CPU Xiao Yang
2018-09-13 7:41 ` Xiao Yang
2018-10-02 11:32 ` Cyril Hrubis
-- strict thread matches above, loose matches on Subject: below --
2018-07-18 7:28 Xiao Yang
2018-07-18 7:10 ` Xiao Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox