From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 4/5] runtest/commands: adjust names for keyctl01, sysctl01, unshare01
Date: Tue, 2 Oct 2018 15:03:39 +0200 [thread overview]
Message-ID: <20181002130338.GG24796@rei> (raw)
In-Reply-To: <1536849882-28897-5-git-send-email-stanislav.kholmanskikh@oracle.com>
Hi!
> runtest/syscalls already defines tests with these ids, but there
> they point to different commands. In order to avoid name conflicts
> we need to rename tests either in runtest/commands or in runtest/syscalls.
> Since the tests in runtest/syscalls are much older, I chose to rename
> the tests in runtest/commands.
>
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> ---
> runtest/commands | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/runtest/commands b/runtest/commands
> index ee7e9f4..f27d2fa 100644
> --- a/runtest/commands
> +++ b/runtest/commands
> @@ -37,7 +37,7 @@ which01 which01.sh
> lsmod01 lsmod01.sh
> insmod01 insmod01.sh
> wc01 wc01.sh
> -keyctl01 keyctl01.sh
> +keyctl_01 keyctl01.sh
> gdb01 gdb01.sh
> -unshare01 unshare01.sh
> -sysctl01 sysctl01.sh
> +unshare_01 unshare01.sh
> +sysctl_01 sysctl01.sh
Hmm, that's a bit hacky. Maybe we should add a _sh suffix to all the
testcases in commands so that it's clear that these are shell scripts.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-10-02 13:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 14:44 [LTP] [RFC] Unique test case ids in runtest files ? Stanislav Kholmanskikh
2018-09-13 14:44 ` [LTP] [RFC PATCH 1/5] Remove the pipes runtest file Stanislav Kholmanskikh
2018-10-02 13:12 ` Cyril Hrubis
2018-09-13 14:44 ` [LTP] [RFC PATCH 2/5] runtest/syscalls: rename CVE test cases Stanislav Kholmanskikh
2018-10-02 12:53 ` Cyril Hrubis
2018-10-02 16:19 ` Stanislav Kholmanskikh
2018-10-08 9:52 ` Stanislav Kholmanskikh
2018-10-08 10:16 ` Cyril Hrubis
2018-09-13 14:44 ` [LTP] [RFC PATCH 3/5] runtest/sched: removed sched_{set, get}attr " Stanislav Kholmanskikh
2018-10-02 12:55 ` Cyril Hrubis
2018-09-13 14:44 ` [LTP] [RFC PATCH 4/5] runtest/commands: adjust names for keyctl01, sysctl01, unshare01 Stanislav Kholmanskikh
2018-10-02 13:03 ` Cyril Hrubis [this message]
2018-10-02 16:21 ` Stanislav Kholmanskikh
2018-10-03 7:42 ` Cyril Hrubis
2018-10-08 9:01 ` Stanislav Kholmanskikh
2018-10-08 9:02 ` Cyril Hrubis
2018-09-13 14:44 ` [LTP] [RFC PATCH 5/5] runtest/numa: remove move_pages* test cases Stanislav Kholmanskikh
2018-10-02 13:09 ` Cyril Hrubis
2018-10-02 16:25 ` Stanislav Kholmanskikh
2018-10-02 12:51 ` [LTP] [RFC] Unique test case ids in runtest files ? Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002130338.GG24796@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox