public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 ltp] runltp: fix shellcheck error for sending email
Date: Mon, 15 Oct 2018 21:07:54 +0200	[thread overview]
Message-ID: <20181015190754.GA26321@dell5510> (raw)
In-Reply-To: <20181015095214.GA32587@dell5510>

Hi Yixin,

> > Signed-off-by: Yixin Zhang <yixin.zhang@intel.com>
> > ---
> >  runltp | 139 +++++++++++++++++++++++++++++++----------------------------------
> >  1 file changed, 67 insertions(+), 72 deletions(-)

> ...
> > +    if [ "$ALT_EMAIL_OUT" -eq 1 ] ; then                    ## User wants reports to be e-mailed
> > +        TAR_FILE_NAME=LTP_RUN_$version_date$DEFAULT_FILE_NAME_GENERATION_TIME.tar
> > +        if [ "$HTMLFILE_NAME" ] ; then                      ## HTML file Exists
> > +            if [ "$ALT_HTML_OUT" -ne 1 ] ; then             ## The HTML file path is absolute and not $LTPROOT/output
> > +                mkdir -p $LTPROOT/output                    ## We need to create this Directory
> > +                cp $HTMLFILE_NAME $LTPROOT/output/
> > +            fi
> > +        fi
> > +        if [ "$OUTPUTFILE_NAME" ] ; then                    ## Output file exists
> > +            if [ "$ALT_DIR_OUT" -ne 1 ] ; then              ## The Output file path is absolute and not $LTPROOT/output
> > +                mkdir -p $LTPROOT/output                    ## We need to create this Directory
> > +                cp $OUTPUTFILE_NAME $LTPROOT/output/
> > +            fi
> > +        fi
> > +        if [ "$LOGFILE_NAME" ] ; then                       ## Log file exists
> As I wrote in comment to v1 [3], $LOGFILE_NAME is always defined, so no need to check for it.
> And the same is for for $OUTPUTFILE_NAME
Although we should omit this check, I ignored that because the state of the file
(it's in maintenance mode). The main point of this commit was to fix basishm and
remove dead branch.

Pushed, with commit message adjustment.
Thanks for your time and care.

Kind regards,
Petr

      parent reply	other threads:[~2018-10-15 19:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26  8:34 [LTP] [PATCH v2 ltp] runltp: fix shellcheck error for sending email Yixin Zhang
2018-10-15  9:52 ` Petr Vorel
2018-10-15 11:19   ` Zhang, Yixin
2018-10-15 14:18   ` Dan Rue
2018-10-15 14:51     ` Cyril Hrubis
2018-10-15 19:16       ` Petr Vorel
2018-10-15 19:07   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181015190754.GA26321@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox