public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/1] net: Fix missing ping6
Date: Fri, 19 Oct 2018 07:38:22 +0200	[thread overview]
Message-ID: <20181019053822.GA19290@dell5510> (raw)
In-Reply-To: <61a9206d-2af4-396a-44dc-ecff4f4ce27f@oracle.com>

Hi Alexey,

> > +if ! tst_cmd_available ping6; then
> > +	ping6()
> > +	{

> What about printing the message on the first usage only?

>                 if [ -z "$ping6_warn_printed" ]; then
>                         tst_res_ TINFO "ping6 ..."
>                         ping6_warn_printed=yes
Make sense. Added with export (required to be working properly).

> The rest looks good.
Applied with your ack-by and suggested-by

Thanks for your comments!


Kind regards,
Petr

      reply	other threads:[~2018-10-19  5:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 14:42 [LTP] [PATCH v2 1/1] net: Fix missing ping6 Petr Vorel
2018-10-18 16:03 ` Alexey Kodanev
2018-10-19  5:38   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181019053822.GA19290@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox