From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] kernel/syscall/setrlimit05.c: use a legal bad address for mips
Date: Mon, 5 Nov 2018 16:22:37 +0100 [thread overview]
Message-ID: <20181105152237.GA3478@rei> (raw)
In-Reply-To: <1541403031-141386-1-git-send-email-hongzhi.song@windriver.com>
Hi!
> diff --git a/testcases/kernel/syscalls/setrlimit/setrlimit05.c b/testcases/kernel/syscalls/setrlimit/setrlimit05.c
> index e716722..57b0b82 100644
> --- a/testcases/kernel/syscalls/setrlimit/setrlimit05.c
> +++ b/testcases/kernel/syscalls/setrlimit/setrlimit05.c
> @@ -31,9 +31,13 @@ static void verify_setrlimit(void)
> int status;
> pid_t pid;
>
> + void *bad_addr;
> +
> + bad_addr = tst_get_bad_addr(NULL);
It would be better if we called this only once in the test setup()
function as the function actually maps a page of memory, the test may
fail if we pass large enough -i parameter.
> pid = SAFE_FORK();
> if (!pid) {
> - TEST(setrlimit(RLIMIT_NOFILE, (void *) -1));
> + TEST(setrlimit(RLIMIT_NOFILE,(struct rlimit *)bad_addr));
> if (TST_RET != -1) {
> tst_res(TFAIL, "setrlimit() succeeded unexpectedly");
> exit(0);
> --
> 2.8.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-11-05 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 7:30 [LTP] [PATCH] kernel/syscall/setrlimit05.c: use a legal bad address for mips Hongzhi.Song
2018-11-05 7:51 ` Xiao Yang
2018-11-06 7:07 ` Hongzhi, Song
2018-11-05 15:22 ` Cyril Hrubis [this message]
2018-11-06 6:36 ` Hongzhi, Song
2018-11-06 16:05 ` Cyril Hrubis
2018-11-06 2:01 ` Xiao Yang
2018-11-06 6:48 ` Hongzhi, Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105152237.GA3478@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox