From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] Question about the usage of tst_brk()
Date: Wed, 7 Nov 2018 12:54:46 +0100 [thread overview]
Message-ID: <20181107115446.GE8603@rei> (raw)
In-Reply-To: <1969756779.70592769.1541590267313.JavaMail.zimbra@redhat.com>
Hi!
> tst_brk is macro in newlib, so maybe we can catch this at compile-time?
Interesting idea, will you look into that?
> > If we wanted to enable TPASS and TFAIL we would have to first define sane
> > semantic for it. I guess that something as "exit currect test process and
> > increment result counters" would be reasonable, this could be done with:
>
> tst_brk() always suggested to me that this is somehow unusual termination
> of test - something's not right with environment or test itself.
>
> Our docs say "Printf-like function to report error and exit the test",
> so my preference would to not use it for "good" outcomes.
Well yes, the name suggests that.
Maybe we just need a few more reporting functions, I was thinking of
adding tst_chk() that would print PASS/FAIL based on expression passed
as first argument, since it seems that several people wanted to have
something like this.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-11-07 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 10:33 [LTP] Question about the usage of tst_brk() Xiao Yang
2018-11-07 10:39 ` Xiao Yang
2018-11-07 11:09 ` Cyril Hrubis
2018-11-07 11:31 ` Jan Stancek
2018-11-07 11:54 ` Cyril Hrubis [this message]
2018-11-07 12:38 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107115446.GE8603@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox