From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 1/2] net: Add tst_net_run helper
Date: Tue, 13 Nov 2018 09:27:24 +0100 [thread overview]
Message-ID: <20181113082724.GC7182@dell5510> (raw)
In-Reply-To: <20181112203723.GC13928@dell5510>
Hi Alexey,
> > > + [ -n "$safe" ] && ROD $cmd || sh -c "$cmd"
> > ^
> > just $cmd?
> Yes, sh -c does not work for shell functions unless are exported
> (tst_test_drivers() in next commit is a shell function).
> I somehow overlooked it.
> But sh -c is used for all test links in tst_rhost_run(),
> I guess we don't want to do export -f FUNCNAME for all functions in tst_net.sh,
> do we?
OK, export -f FUNCNAME is a bashism, we cannot use it.
I'll check whether we can replace sh -c with brackets.
If not, tst_rhost_run() won't be able to use functions (just binaries).
Kind regards,
Petr
next prev parent reply other threads:[~2018-11-13 8:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 14:24 [LTP] [PATCH v3 1/2] net: Add tst_net_run helper Petr Vorel
2018-11-08 14:24 ` [LTP] [PATCH v3 2/2] net/ipsec: Add check for xfrm_user Petr Vorel
2018-11-12 17:33 ` Alexey Kodanev
2018-11-12 16:19 ` [LTP] [PATCH v3 1/2] net: Add tst_net_run helper Alexey Kodanev
2018-11-12 20:37 ` Petr Vorel
2018-11-13 8:27 ` Petr Vorel [this message]
2018-11-13 15:26 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113082724.GC7182@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox