From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Tue, 13 Nov 2018 16:26:51 +0100 Subject: [LTP] [PATCH v3 1/2] net: Add tst_net_run helper In-Reply-To: <20181113082724.GC7182@dell5510> References: <20181108142409.4955-1-pvorel@suse.cz> <20181112203723.GC13928@dell5510> <20181113082724.GC7182@dell5510> Message-ID: <20181113152651.GA3712@dell5510> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Alexey, > > > > + [ -n "$safe" ] && ROD $cmd || sh -c "$cmd" > > > ^ > > > just $cmd? > > Yes, sh -c does not work for shell functions unless are exported > > (tst_test_drivers() in next commit is a shell function). > > I somehow overlooked it. > > But sh -c is used for all test links in tst_rhost_run(), > > I guess we don't want to do export -f FUNCNAME for all functions in tst_net.sh, > > do we? > OK, export -f FUNCNAME is a bashism, we cannot use it. > I'll check whether we can replace sh -c with brackets. > If not, tst_rhost_run() won't be able to use functions (just binaries). OK, execvp() used in testcases/kernel/containers/share/ns_exec.c (used for netns) requires binary. I guess I have to live with the fact that tst_rhost_run() is not able to call shell functions. Kind regards, Petr