From: Amir Goldstein <amir73il@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/5] syscalls/fanotify03: check permission events also on mountpoint mark
Date: Fri, 16 Nov 2018 08:51:16 +0200 [thread overview]
Message-ID: <20181116065119.6912-3-amir73il@gmail.com> (raw)
In-Reply-To: <20181116065119.6912-1-amir73il@gmail.com>
Add index to test and repeat it for mark types inode and mountpoint.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
.../kernel/syscalls/fanotify/fanotify03.c | 34 +++++++++++++++----
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/testcases/kernel/syscalls/fanotify/fanotify03.c b/testcases/kernel/syscalls/fanotify/fanotify03.c
index 42aac813e..19daf57ef 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify03.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify03.c
@@ -47,6 +47,20 @@ static unsigned int event_resp[EVENT_MAX];
static char event_buf[EVENT_BUF_LEN];
+static struct tcase {
+ const char *tname;
+ struct fanotify_mark_type mark;
+} tcases[] = {
+ {
+ "inode mark permission events",
+ INIT_FANOTIFY_MARK_TYPE(INODE),
+ },
+ {
+ "mount mark permission events",
+ INIT_FANOTIFY_MARK_TYPE(MOUNT),
+ },
+};
+
static void generate_events(void)
{
int fd;
@@ -120,11 +134,14 @@ static void check_child(void)
tst_res(TFAIL, "child %s", tst_strstatus(child_ret));
}
-static void setup_mark(void)
+static void setup_mark(unsigned int n)
{
+ struct tcase *tc = &tcases[n];
+ struct fanotify_mark_type *mark = &tc->mark;
+
fd_notify = SAFE_FANOTIFY_INIT(FAN_CLASS_CONTENT, O_RDONLY);
- if (fanotify_mark(fd_notify, FAN_MARK_ADD,
+ if (fanotify_mark(fd_notify, FAN_MARK_ADD | mark->flag,
FAN_ACCESS_PERM | FAN_OPEN_PERM,
AT_FDCWD, fname) < 0) {
if (errno == EINVAL) {
@@ -133,20 +150,22 @@ static void setup_mark(void)
"configured in kernel?");
} else {
tst_brk(TBROK | TERRNO,
- "fanotify_mark (%d, FAN_MARK_ADD, "
+ "fanotify_mark (%d, FAN_MARK_ADD | %s, "
"FAN_ACCESS_PERM | FAN_OPEN_PERM, "
"AT_FDCWD, %s) failed.",
- fd_notify, fname);
+ fd_notify, mark->name, fname);
}
}
+
+ tst_res(TINFO, "Test #%d: %s", n, tc->tname);
}
-void test01(void)
+static void test_fanotify(unsigned int n)
{
int tst_count;
int ret, len = 0, i = 0, test_num = 0;
- setup_mark();
+ setup_mark(n);
run_child();
tst_count = 0;
@@ -247,7 +266,8 @@ static void cleanup(void)
}
static struct tst_test test = {
- .test_all = test01,
+ .test = test_fanotify,
+ .tcnt = ARRAY_SIZE(tcases),
.setup = setup,
.cleanup = cleanup,
.needs_tmpdir = 1,
--
2.17.1
next prev parent reply other threads:[~2018-11-16 6:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 6:51 [LTP] [PATCH 0/5] fanotify filesystem mark tests Amir Goldstein
2018-11-16 6:51 ` [LTP] [PATCH 1/5] syscalls/fanotify01: check events also on mountpoint mark Amir Goldstein
2018-11-21 12:01 ` Cyril Hrubis
2018-11-21 16:18 ` Amir Goldstein
2018-11-22 16:06 ` Cyril Hrubis
2018-11-22 16:57 ` Amir Goldstein
2018-11-16 6:51 ` Amir Goldstein [this message]
2018-11-21 12:26 ` [LTP] [PATCH 2/5] syscalls/fanotify03: check permission " Cyril Hrubis
2018-11-16 6:51 ` [LTP] [PATCH 3/5] syscalls/fanotify01: add test for FAN_MARK_FILESYSTEM events Amir Goldstein
2018-11-21 13:00 ` Cyril Hrubis
2018-11-16 6:51 ` [LTP] [PATCH 4/5] syscalls/fanotify03: add test for FAN_MARK_FILESYSTEM permission events Amir Goldstein
2018-11-21 13:14 ` Cyril Hrubis
2018-11-21 16:36 ` Amir Goldstein
2018-11-21 17:10 ` Amir Goldstein
2018-11-22 16:03 ` Cyril Hrubis
2018-11-16 6:51 ` [LTP] [PATCH 5/5] syscalls/fanotify10: add tests for FAN_MARK_FILESYSTEM and ignore mask Amir Goldstein
2018-11-21 13:27 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116065119.6912-3-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox