public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] commands/logrotate_tests.sh: Fix two issues
Date: Wed, 28 Nov 2018 08:00:37 +0100	[thread overview]
Message-ID: <20181128070037.GA30353@dell5510> (raw)
In-Reply-To: <1542886783-30763-1-git-send-email-yangx.jy@cn.fujitsu.com>

Hi Xiao,

> 1) Pass correct arguments when calling tst_res command in logrotate_tests.sh
> 2) If syslog group doesn't exist on system, su option with it triggers a
>    an 'unknow group' error in config file and then skips the config file.
>    e.g.  Running logrotate_sh gets either of the following errors, because
>    logrotate command with above error returns non-zero exit status since
>    commit e547b94 in logrotate:
>    ---------------------------------------------------------
>    logrotate01    1  TFAIL  :  ltpapicmd.c:154: Test #1: logrotate command failed. Reason:
>    ...
>    logrotate01    1  TFAIL  :  ltpapicmd.c:154: Test #1: logrotate command exited with 1 return code. Output:
>    ---------------------------------------------------------
>    We just use syslog group if it actually exists.

> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
>  testcases/commands/logrotate/logrotate_tests.sh | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

thanks for your commit, pushed with some changes (I split commit into 2,
adjusted commit message, simplify variable name and reverse check logic to not
repeat group name).

Kind regards,
Petr

      reply	other threads:[~2018-11-28  7:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22 11:39 [LTP] [PATCH] commands/logrotate_tests.sh: Fix two issues Xiao Yang
2018-11-28  7:00 ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128070037.GA30353@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox