[LTP] [PATCH 1/2] getrlimit/getrlimit03: add configure-time check for struct ulimit64

Greg Hackmann
2018-12-03T22:20:25Z

On 12/03/2018 01:25 PM, Petr Vorel wrote:
> Glibc and uclibc-ng define struct rlimit64 only #ifdef __USE_LARGEFILE64.

Makes sense. I ran into this issue with bionic, which doesn't require
-D_LARGEFILE64_SOURCE for these kinds of definitions.

> Would it make sense to change autoconf test to AC_COMPILE_IFELSE and pass -D_LARGEFILE64_SOURCE to it?
> + Use it in Makefile, of course.
>
>
> Kind regards,
> Petr
>

I'm honestly not that familiar with autotools, so I'm not sure I follow
this. Are you suggesting that we assume struct rlimit64 is defined
(possibly conditionally on -D_LARGEFILE64_SOURCE), and we really ought
to probe whether -D_LARGEFILE64_SOURCE is required to make it visible?