[LTP] [PATCH 2/2] lib: build check parameters for tst_brk()

Petr Vorel
2018-12-04T17:35:42Z

Hi Jan,

Reviewed-by: Petr Vorel <pvorel@suse.cz>

> > Perhaps, we could add some hints about the invalid ttype.
> > e.g. "tst_brk(): invalid type, please use TBROK/TCONF/TFAIL"

> Do you have suggestion how to achieve that?

> There's an __attribute__(error), but it's supported only from gcc 4.3 as I recall.
Do you mean __attribute__ format?

> Alternative would be link time failure, with a symbol name suggesting what went wrong.
Not sure, how exactly you want to do it, but seems to be more portable than
requiring specific gcc version (although 4.3 is very old and __attribute__
format is supported by clang as well).

Kind regards,
Petr