From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] lib: build check parameters for tst_brk()
Date: Tue, 4 Dec 2018 18:35:42 +0100 [thread overview]
Message-ID: <20181204173542.GD30799@dell5510> (raw)
In-Reply-To: <1582215982.71956713.1541786229415.JavaMail.zimbra@redhat.com>
Hi Jan,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > Perhaps, we could add some hints about the invalid ttype.
> > e.g. "tst_brk(): invalid type, please use TBROK/TCONF/TFAIL"
> Do you have suggestion how to achieve that?
> There's an __attribute__(error), but it's supported only from gcc 4.3 as I recall.
Do you mean __attribute__ format?
> Alternative would be link time failure, with a symbol name suggesting what went wrong.
Not sure, how exactly you want to do it, but seems to be more portable than
requiring specific gcc version (although 4.3 is very old and __attribute__
format is supported by clang as well).
Kind regards,
Petr
next prev parent reply other threads:[~2018-12-04 17:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 20:59 [LTP] [PATCH 1/2] syscalls/mq: don't use TWARN with tst_brk() Jan Stancek
2018-11-08 20:59 ` [LTP] [PATCH 2/2] lib: build check parameters for tst_brk() Jan Stancek
2018-11-09 1:56 ` Xiao Yang
2018-11-09 17:57 ` Jan Stancek
2018-12-04 17:35 ` Petr Vorel [this message]
2018-12-05 6:34 ` Li Wang
2018-12-05 9:25 ` Petr Vorel
2018-12-06 8:49 ` Li Wang
2018-12-06 9:19 ` Xiao Yang
2018-12-06 10:15 ` Li Wang
2018-12-06 10:33 ` Li Wang
2018-12-06 12:59 ` Petr Vorel
2018-12-06 13:07 ` Petr Vorel
2018-12-07 6:28 ` Li Wang
2018-12-11 14:58 ` Cyril Hrubis
2019-01-03 11:52 ` Jan Stancek
2019-01-07 18:25 ` Cyril Hrubis
2019-01-07 19:06 ` Jan Stancek
2019-01-07 19:22 ` Cyril Hrubis
2019-01-08 11:14 ` Jan Stancek
2018-12-04 16:58 ` [LTP] [PATCH 1/2] syscalls/mq: don't use TWARN with tst_brk() Petr Vorel
2018-12-11 14:48 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204173542.GD30799@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox