From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] getrlimit03: Allow for missing getrlimit syscall at runtime
Date: Tue, 11 Dec 2018 09:57:45 +0100 [thread overview]
Message-ID: <20181211085745.GA2824@dell5510> (raw)
In-Reply-To: <20181210131952.27010-1-rpalethorpe@suse.com>
Hi Richard,
> It appears that __NR_getrlimit can be missing or disabled in the kernel. For
> example this appears to be the case on the PPC64le platform. So this changes
> the test to return TCONF under these circumstances as this system call is
> redundant and libc can implement it in terms of other calls.
> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> ---
...
> #if SIGNED_GETRLIMIT
> + if (seen_getrlimit_nosys)
> + goto EXIT;
> +
> errno = 0;
> ret_l = getrlimit_long(resource, &rlim_l);
> errno_l = errno;
> + if (errno_l == ENOSYS) {
> + tst_res(TCONF,
> + "__NR_getrlimit(%d) is not present", __NR_getrlimit);
> + seen_getrlimit_nosys = 1;
> + return;
> + }
> +
> if (compare_retval(resource, ret_u64, errno_u64, ret_l, errno_l,
> "__NR_getrlimit") ||
> compare_u64_long(resource, rlim_u64.rlim_cur, rlim_l.rlim_cur,
> @@ -172,6 +184,7 @@ static void run(unsigned int resource)
> return;
> #endif
> +EXIT:
Minor issue: EXIT should be before #endif (otherwise it issues warning on !SIGNED_GETRLIMIT.
> tst_res(TPASS, "getrlimit(%u) was consistent during all syscalls",
> resource);
> }
Kind regards,
Petr
prev parent reply other threads:[~2018-12-11 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 13:19 [LTP] [PATCH] getrlimit03: Allow for missing getrlimit syscall at runtime Richard Palethorpe
2018-12-11 8:57 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211085745.GA2824@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox