From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v5] syscalls/readahead02: test readahead using posix_fadvise()
Date: Tue, 18 Dec 2018 14:01:07 +0100 [thread overview]
Message-ID: <20181218130107.GB18871@rei.lan> (raw)
In-Reply-To: <20181204153528.26176-1-amir73il@gmail.com>
Hi!
Sorry for the delay.
...
> - if (ret == EINVAL &&
> - (!tc->use_overlay || !readahead_supported)) {
> - readahead_supported = 0;
> - tst_res(TCONF, "readahead not supported on %s",
> - tst_device->fs_type);
> - return;
> + if (ret == EINVAL) {
> + if (tc->use_fadvise &&
> + (!tc->use_overlay || !fadvise_supported)) {
> + fadvise_supported = 0;
> + tst_res(TCONF, "CONFIG_ADVISE_SYSCALLS not configured "
> + "in kernel?");
> + return;
> + } else if (!tc->use_overlay || !readahead_supported) {
I got rid of the else block here, since we do return at the end of the
if block before it anyways and pushed, thanks.
> + readahead_supported = 0;
> + tst_res(TCONF, "readahead not supported on %s",
> + tst_device->fs_type);
> + return;
> + }
> }
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2018-12-18 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 15:35 [LTP] [PATCH v5] syscalls/readahead02: test readahead using posix_fadvise() Amir Goldstein
2018-12-14 18:18 ` Amir Goldstein
2018-12-18 13:01 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218130107.GB18871@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox