From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] Test statx syscall for SYNC_FLAGS
Date: Thu, 20 Dec 2018 09:20:09 +0100 [thread overview]
Message-ID: <20181220082009.GA27700@dell5510> (raw)
In-Reply-To: <20180917075248.28004-1-kewal@zilogic.com>
Hi Kewal,
> +++ b/testcases/kernel/syscalls/statx/statx07.c
...
> + * Minimum kernel version required is 4.11.
> + */
One more thing, you need to define _GNU_SOURCE here as it's needed for glibc and
thus used for detection in m4/ltp-statx.m4.
#define _GNU_SOURCE
> +#include <netdb.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <linux/limits.h>
> +#include <sys/mount.h>
> +#include "tst_test.h"
> +#include "lapi/stat.h"
Without it it fails on glibc >= 2.28
https://travis-ci.org/pevik/ltp/builds/470077800
I thing it'd be better to remove _GNU_SOURCE from statx0*.c and put it into
lapi/stat.h.
Kind regards,
Petr
next prev parent reply other threads:[~2018-12-20 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 7:52 [LTP] [PATCH v2] Test statx syscall for SYNC_FLAGS kewal
2018-11-27 11:59 ` Petr Vorel
2018-12-20 8:20 ` Petr Vorel [this message]
2018-12-21 11:06 ` vaishnavi.d
2018-12-21 12:22 ` Petr Vorel
2018-12-26 6:57 ` vaishnavi.d
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220082009.GA27700@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox