public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] controllers/cpuacct.sh: Fix timeout for cpuacct.sh
Date: Thu, 20 Dec 2018 15:22:43 +0100	[thread overview]
Message-ID: <20181220142243.GA30787@dell5510> (raw)
In-Reply-To: <1544087108-5717-1-git-send-email-yangx.jy@cn.fujitsu.com>

Hi Xiao,

> With commit fbea02a, cpuacct.sh always gets timeout because wait
> command tries to wait all background processes including the timeout
> process.  We should just wait the processes created for test.

> e.g. running cpuacct_1_1 gets the following timeout:
> -----------------------------------------------------------
> cpuacct 1 TINFO: timeout per run is 0h 5m 0s
> cpuacct 1 TINFO: cpuacct:
> cpuacct 1 TINFO: Creating 1 subgroups each with 1 processes
> cpuacct 1 TBROK: test killed, timeout!
> -----------------------------------------------------------

> Fixes: fbea02a("lib/tst_test.sh: setup timeout per test run for the shell tests")
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>

Thanks for your fix, merged.

I look for other plain wait usage, this was the only one using new shell API.

Kind regards,
Petr

      parent reply	other threads:[~2018-12-20 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06  9:05 [LTP] [PATCH] controllers/cpuacct.sh: Fix timeout for cpuacct.sh Xiao Yang
2018-12-20  6:05 ` Xiao Yang
2018-12-20 14:22 ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181220142243.GA30787@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox