From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Fri, 21 Dec 2018 16:47:44 +0100 Subject: [LTP] [PATCH v2 0/4] cgroup tests newlib-porting In-Reply-To: <6645abe6-4ab0-a1b2-6351-41325eff720b@arm.com> References: <20181220182149.48326-1-cristian.marussi@arm.com> <20181221133904.GA27446@dell5510> <6645abe6-4ab0-a1b2-6351-41325eff720b@arm.com> Message-ID: <20181221154744.GA13971@dell5510> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Cristian, > > You left big copyright in cpuacct.sh. > In this patch I have NOT touched anything else than the content of > testcases/kernel/controllers/cgroup which are files related to the > cgroup_regression_test.sh testcase; the file you mentioned is in > testcases/kernel/controllers/cpuacct/ ... am I missing something ? Sorry, I was wrong. > > Can you please squash it into single commit? > > Or in two (first cleanup & rewrite of group_regression_test.sh, second for > > helpers). It does not bring much to split it like this. > Ok I'll squash..I splitted thinking it could have been complained of being not > splitted :D For small changes we like to have it atomic (split), but rewrite is IMHO better do it in one commit or two (group_regression_test.sh and then the rest - that's up to you). I focus too much on details for tests which are for very old kernel. > > I guess fork_processes.c and getdelays.c can be using new C API as well. > > You don't have to do it, but it can bring benefits (using tst_res(), info about > > command). > I'll review those too...I focused only on the shell-scripts logic ... not sure > why in fact. I'd prefer to convert it to new C API or leave it as they are. Kind regards, Petr