public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3]  cgroup_regression_test.sh ported to newlib
Date: Fri, 4 Jan 2019 04:45:55 +0100	[thread overview]
Message-ID: <20190104034555.GA5992@dell5510> (raw)
In-Reply-To: <20181221182516.45689-1-cristian.marussi@arm.com>

Hi Cristian,

> Ported to newlib and cleaned up.

>  - removed absolute/relative commands invocations
>  - avoid bashism
>   + removed bash shebang
>   + giving up 'kill' bash-builtin: this needs redefining
>     used sigspec strings
>  - A common function 'get_cgroup_mountpoint' is added to help
>    parse /proc/mounts in search of specific cgroup subsystems
>    mountpoints. It is added as part of a common cgroup_lib.sh.
>  - converted Copyright headers to SPDX
>  - renamed each helper to include a tag prefix (cgroup_regress_)
>    in order to avoid possible name clashes once installed all together
>    into testcases/bin

> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks for your patch, merged with several code style changes:
 - unify file names (cgroup_regress_* => cgroup_regression_)
 - rename also getdelays.c and fork_processes.c
 - redirect wait's stderr to /dev/null to keep it quiet
 - remove mandatory commands from TST_NEEDS_CMDS
 - move tst_test.sh loading into library
 - cleanup get_cgroup_mountpoint()
 - minor code style fixes

See diff bellow. I also added 4 commits related to this test,
one of them is fixing regression I added while changing your code
(I'm sorry).

Kind regards,
Petr

  reply	other threads:[~2019-01-04  3:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-21 18:25 [LTP] [PATCH v3] cgroup_regression_test.sh ported to newlib Cristian Marussi
2019-01-04  3:45 ` Petr Vorel [this message]
2019-01-04 10:21   ` Cristian Marussi
2019-01-04 12:25     ` Petr Vorel
2019-01-04 12:28       ` Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190104034555.GA5992@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox