public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] device-drivers/cpufreq_boost.c: skip test if turbo is disabled by BIOS or unavailable on processor
Date: Tue, 8 Jan 2019 10:33:44 +0100	[thread overview]
Message-ID: <20190108093344.GA2687@x230> (raw)
In-Reply-To: <1546852515-19045-1-git-send-email-yangx.jy@cn.fujitsu.com>

Hi Xiao,

> If intel_pstate driver has been initialized but turbo is disabled by BIOS
> or unavailable on processor(i.e. intel_pstate/no_turbo file exists but its
> default value is 1), we cannot write data into intel_pstate/no_turbo and
> return EPERM, as below:
> ------------------------------------------------------------------------
> cpufreq_boost    1  TBROK  :  safe_file_ops.c:301: Failed to close FILE '/sys/devices/system/cpu/intel_pstate/no_turbo' at cpufreq_boost.c:151: errno=EPERM(1): Operation not permitted
> cpufreq_boost    2  TBROK  :  safe_file_ops.c:301: Remaining cases broken
> ------------------------------------------------------------------------

> We try to skip test in this case.

> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Acked-by: Petr Vorel <pvorel@suse.cz>

Not merging it as it's a git freeze (although it's a fix).

> +	/* We try to skip test when getting EPERM. */
> +	if (write(fd, off, 1) == -1 && errno == EPERM) {
> +		SAFE_CLOSE(NULL, fd);
> +		tst_brkm(TCONF, NULL, "Turbo is disabled by "
> +			 "BIOS or unavailable on processor");
Minor tip: I wouldn't split the string (better for grep, also checkpatch.pl
warns about it).

Kind regards,
Petr

  reply	other threads:[~2019-01-08  9:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07  9:15 [LTP] [PATCH] device-drivers/cpufreq_boost.c: skip test if turbo is disabled by BIOS or unavailable on processor Xiao Yang
2019-01-08  9:33 ` Petr Vorel [this message]
2019-01-08  9:46   ` Xiao Yang
2019-01-08 10:10     ` Cristian Marussi
2019-01-08 10:52       ` Xiao Yang
2019-01-08 11:27       ` Petr Vorel
2019-01-23 17:27         ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190108093344.GA2687@x230 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox