public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] change ip command of route6-change-gw
Date: Tue, 15 Jan 2019 15:02:42 +0100	[thread overview]
Message-ID: <20190115140241.GA16344@dell5510> (raw)
In-Reply-To: <20190115020846.625-1-yangj.fnst@cn.fujitsu.com>

Hi Jian,

> when useing old ip commond to test,it will get the following
>  error:

> RTNETLINK answers: File exists

> So I changed this case like the ip command of route4-change-gw
> Signed-off-by:jian yang <yangj.fnst@cn.fujitsu.com>
> ---
>  testcases/network/stress/route/route6-change-gw | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

> diff --git a/testcases/network/stress/route/route6-change-gw b/testcases/network/stress/route/route6-change-gw
> index 96fd7ee66..05e45b907 100644
> --- a/testcases/network/stress/route/route6-change-gw
> +++ b/testcases/network/stress/route/route6-change-gw
> @@ -245,8 +245,7 @@ test_body()
>  	    route -A inet6 del ${dst_network}/64 gw ${IPV6_NETWORK}:${pre_rhost_part_hex} dev $lhost_ifname
>  	    ;;
>  	    2)
> -	    ip -f inet6 route add ${dst_network}/64 via ${IPV6_NETWORK}:${rhost_part_hex} dev $lhost_ifname
> -	    ip -f inet6 route del ${dst_network}/64 via ${IPV6_NETWORK}:${pre_rhost_part_hex} dev $lhost_ifname
> +	    ip -f inet6 route change ${dst_network}/64 via ${IPV6_NETWORK}:${rhost_part_hex} dev $lhost_ifname
>  	    ;;
>  	esac
>  	if [ $? -ne 0 ]; then

Thanks for your patch, merged.

FYI these tests are in terrible state, needs complete rewrite, see [1].
I've already had several attempts in the past, last one [2] still wasn't good
enough. Currently I'm rewritting route*-change-* tests into C using rtnetlink.

Kind regards,
Petr

[1] https://github.com/linux-test-project/ltp/issues/440
[2] https://patchwork.ozlabs.org/project/ltp/list/?series=44924&state=*

  reply	other threads:[~2019-01-15 14:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15  2:08 [LTP] [PATCH] change ip command of route6-change-gw yangj
2019-01-15 14:02 ` Petr Vorel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-01-15 10:55 yangj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190115140241.GA16344@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox