From mboxrd@z Thu Jan  1 00:00:00 1970
From: Petr Vorel <pvorel@suse.cz>
Date: Tue, 15 Jan 2019 20:13:16 +0100
Subject: [LTP] added SAFE_SOCKETPAIR()
In-Reply-To: <20181211200803.GA23351@x230>
References: <515a2ca2-1f68-d2d1-524d-f4fc89be337d@google.com>
 <20181211200803.GA23351@x230>
Message-ID: <20190115191315.GA19090@dell5510>
List-Id: <ltp.lists.linux.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ltp@lists.linux.it

Hi Ramon,

> ...
> > +++ b/lib/safe_net.c
> > @@ -132,6 +132,34 @@ int safe_socket(const char *file, const int lineno, void (cleanup_fn)(void),
> >  	return rval;
> >  }
> > +int safe_socketpair(const char *file, const int lineno, int domain, int type,
> > +		    int protocol, int sv[])
> > +{
> > +	int rval, ttype;
> > +
> > +	rval = socketpair(domain, type, protocol, sv);
> > +
> > +	if (rval < 0) {
> > +		switch (errno) {
> > +		case EPROTONOSUPPORT:
> > +		case ESOCKTNOSUPPORT:
> > +		case EOPNOTSUPP:
> > +		case EPFNOSUPPORT:
> > +		case EAFNOSUPPORT:
> > +			ttype = TCONF;
> > +			break;
> > +		default:
> > +			ttype = TBROK;
> > +		}
> It looks like you copy paste errno's from safe_socket(). While it does not harm
> to have more errno's, I guess these to never come: ESOCKTNOSUPPORT, EPFNOSUPPORT.
> They're listed in safe_socket() as man socket(2) says "Other errors may be
> generated by the underlying protocol modules.", it was needed to ad them.

> Otherwise LGTM.

Merged with this change.
Thanks for your work.


Kind regards,
Petr