From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] syscalls: Add set_mempolicy numa tests.
Date: Wed, 16 Jan 2019 13:36:21 +0100 [thread overview]
Message-ID: <20190116123621.GA24833@rei> (raw)
In-Reply-To: <1825051207.96340275.1547639365640.JavaMail.zimbra@redhat.com>
Hi!
> > > I think all the alloc stuff shouldn't be in library. It's quite
> > > possible tests will need different ways to allocate memory.
> > >
> > > Maybe the test will want to mmap, but not touch any pages,
> > > or pass different flags to mmap. Allocate with other functions
> > > than mmap, etc.
> >
> > It should be put into some kind of common place though since it's used
> > from several tests even at this point.
>
> set_mempolicy sub-dir?
That wouldn't not work once I will add mbind tests.
> > What about splitting the tst_numa_alloc_parse() to tst_numa_alloc() and
> > tst_numa_parse() and keeping the functionality in the library?
>
> That looks more flexible.
>
> Though I'm not 100% sold on single alloc func in library. My concern is
> it will be difficult for it to cover all possible scenarios and API
> will keep changing as we find more.
The worst that can happen is that we will end up with a few alloc
functions each for different purpose, but I do not think that this is
necessarily bad.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2019-01-16 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 15:57 [LTP] [PATCH v3] syscalls: Add set_mempolicy numa tests Cyril Hrubis
2019-01-03 11:39 ` Jan Stancek
2019-01-16 11:12 ` Cyril Hrubis
2019-01-16 11:49 ` Jan Stancek
2019-01-16 12:36 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116123621.GA24833@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox