From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] ustat: Fix EFAULT in 32bit compatability mode
Date: Thu, 7 Feb 2019 14:07:46 +0100 [thread overview]
Message-ID: <20190207130746.GB20833@dell5510> (raw)
In-Reply-To: <532035050.101837579.1549541815701.JavaMail.zimbra@redhat.com>
Hi Jan,
> > From looking at glibc, this test may also be broken on mips, but I am not
> > sure
> > if that matters. AFAICT on all other platforms glibc always casts to uint
> > after performing a sanity check..
> LGTM, LTP is using only 0 (and -1 for errno tests), so it shouldn't matter.
I'm sorry I missed your mail, so pushed without your ack.
> What about ustat02? Are you planning on sending something similar for that test?
It's not needed for ustat02. Is it because *tc[test].dev in ustat02 is pointer?
Kind regards,
Petr
next prev parent reply other threads:[~2019-02-07 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 0:17 [LTP] [PATCH v2] syscalls/ustat: convert to new lib, use direct syscall Steve Muckle
2019-02-04 12:55 ` Petr Vorel
2019-02-07 10:18 ` [LTP] [PATCH] ustat: Fix EFAULT in 32bit compatability mode Richard Palethorpe
2019-02-07 12:16 ` Jan Stancek
2019-02-07 13:07 ` Petr Vorel [this message]
2019-02-07 14:38 ` Richard Palethorpe
2019-02-07 12:52 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207130746.GB20833@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox