From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls: add syscall syncfs test
Date: Fri, 15 Feb 2019 13:16:11 +0100 [thread overview]
Message-ID: <20190215121611.GA14270@rei> (raw)
In-Reply-To: <CAFA6WYO8qg79rQ-qwU3i6FpfNRQhiTNXzGHtDsJ6FpTty6W77g@mail.gmail.com>
Hi!
> > 1) Compilation failed on older kernel(e.g. v2.6.32) because of the
> > undefined syncfs().
> > According to manpage, syncfs() was first appeared in Linux 2.6.39 and
> > library
> > support was added to glibc in version 2.14. Perhaps, we need to check if
> > syncfs()
> > is defined.
> >
>
> Would configuring .min_kver suffice to avoid this compilation issue?
Not at all, min_kver is runtime check, which could solve the latter
problem.
For this you can either:
* Add a configure check for syscfs()
* Add a fallback syscall definition to header include/lapi/
Fallback definition is preferable solution since with that the test will
still work on old userspace with new kernel.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-02-15 12:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 7:17 [LTP] [PATCH v2] syscalls: add syscall syncfs test Sumit Garg
2019-02-15 7:55 ` Xiao Yang
2019-02-15 11:58 ` Sumit Garg
2019-02-15 12:16 ` Cyril Hrubis [this message]
2019-02-15 13:18 ` Sumit Garg
2019-02-15 13:22 ` Cyril Hrubis
2019-02-15 13:25 ` Cyril Hrubis
2019-02-15 13:51 ` Sumit Garg
2019-02-16 0:17 ` Steve Muckle
2019-02-18 7:52 ` Sumit Garg
2019-02-18 12:24 ` Cyril Hrubis
2019-02-18 11:57 ` Cyril Hrubis
2019-02-19 23:15 ` Steve Muckle
2019-02-20 13:14 ` Cyril Hrubis
2019-02-20 15:12 ` Cyril Hrubis
2019-02-22 19:58 ` Steve Muckle
2019-02-19 6:44 ` Sumit Garg
2019-02-21 7:08 ` Sumit Garg
2019-02-15 8:42 ` Amir Goldstein
2019-02-15 13:03 ` Cyril Hrubis
2019-02-15 13:38 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215121611.GA14270@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox