From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] adding s390x tests to ltp
Date: Mon, 18 Feb 2019 19:21:38 +0100 [thread overview]
Message-ID: <20190218182137.GA27553@dell5510> (raw)
In-Reply-To: <1740320205.101841684.1549543929404.JavaMail.zimbra@redhat.com>
Hi Jan, Cyril,
> Maybe also: TST_NEEDS_CMDS="vmcp" ?
> Not sure if all s390x distros have this command installed.
> But that should also be sufficient check to run this on any arch,
> if command doesn't exist it will TCONF.
The reason, why I suggested to move these tests to upstream [1]
is that testing "vmcp --version" or "vmcp --help" does not really depend on
anyhow on SUT. Adding it to upstream into make check (there are none check yet)
would bring 1) earlier catch of potencial bugs as upstream developers can run it
for each commit (CI) and distros during package build.
We had some discussion before about removing some user space packages [2].
Cyril suggested to to keep tests that are working with files (cp/df/ln)
and remove at least unzip and wc.
Doing some real testing (really using vmcp.ko) would make this tests useful to
run on LTP, but current code IMHO does nothing with kernel. Or do I miss
something?
Anyway, it looks like you have no objection about adding it to LTP, so I changed
state of this test New. In that case, I suggest to
remove debugging:
> +#set -x
> +#
use tst_res TINFO instead of echo
+ echo "verifyBasicVMCPCommands"
+ echo "verifyErrorCondition"
Kind regards,
Petr
[1] https://github.com/ibm-s390-tools/s390-tools
[2] https://patchwork.ozlabs.org/patch/905064/#1902070
next prev parent reply other threads:[~2019-02-18 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 16:13 [LTP] [PATCH] adding s390x tests to ltp Elif Aslan
2019-02-04 23:51 ` Petr Vorel
2019-02-07 12:52 ` Jan Stancek
2019-02-07 12:54 ` Cyril Hrubis
2019-02-18 18:21 ` Petr Vorel [this message]
2019-02-18 18:33 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218182137.GA27553@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox