From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/4] ima, commands/{df,mkfs}: Use tst_mount
Date: Wed, 20 Feb 2019 17:20:12 +0100 [thread overview]
Message-ID: <20190220162014.5467-2-pvorel@suse.cz> (raw)
In-Reply-To: <20190220162014.5467-1-pvorel@suse.cz>
to reduce duplicity.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/commands/df/df01.sh | 18 +++---------------
testcases/commands/mkfs/mkfs01.sh | 15 +--------------
.../security/integrity/ima/tests/ima_setup.sh | 9 ++-------
3 files changed, 6 insertions(+), 36 deletions(-)
diff --git a/testcases/commands/df/df01.sh b/testcases/commands/df/df01.sh
index ecd66fbd6..4f77500b8 100755
--- a/testcases/commands/df/df01.sh
+++ b/testcases/commands/df/df01.sh
@@ -55,26 +55,14 @@ setup()
tst_test_cmds mkfs.${FS_TYPE}
fi
- tst_mkfs ${FS_TYPE} ${TST_DEVICE}
-
- ROD_SILENT mkdir -p mntpoint
-
- mount ${TST_DEVICE} mntpoint
- ret=$?
- if [ $ret -eq 32 ]; then
- tst_brk TCONF "Cannot mount ${FS_TYPE}, missing driver?"
- fi
-
- if [ $ret -ne 0 ]; then
- tst_brk TBROK "Failed to mount device: mount exit = $ret"
- fi
-
+ tst_mkfs $FS_TYPE $TST_DEVICE
+ tst_mount
DF_FS_TYPE=$(mount | grep "$TST_DEVICE" | awk '{print $5}')
}
cleanup()
{
- tst_umount ${TST_DEVICE}
+ tst_umount $TST_DEVICE
}
df_test()
diff --git a/testcases/commands/mkfs/mkfs01.sh b/testcases/commands/mkfs/mkfs01.sh
index 68d40830a..25d185a05 100755
--- a/testcases/commands/mkfs/mkfs01.sh
+++ b/testcases/commands/mkfs/mkfs01.sh
@@ -54,19 +54,6 @@ setup()
ROD_SILENT mkdir -p mntpoint
}
-mkfs_mount()
-{
- mount ${TST_DEVICE} mntpoint
- local ret=$?
- if [ $ret -eq 32 ]; then
- tst_brk TCONF "Cannot mount ${FS_TYPE}, missing driver?"
- fi
-
- if [ $ret -ne 0 ]; then
- tst_brk TBROK "Failed to mount device: mount exit = $ret"
- fi
-}
-
mkfs_verify_type()
{
if [ -z "$1" ]; then
@@ -82,7 +69,7 @@ mkfs_verify_type()
mkfs_verify_size()
{
- mkfs_mount
+ tst_mount
local blocknum=`df -P -B 1k mntpoint | tail -n1 | awk '{print $2}'`
tst_umount "$TST_DEVICE"
diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
index fe6098135..e51d3d70b 100644
--- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
+++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
@@ -55,13 +55,8 @@ mount_loop_device()
tst_test_cmds mkfs.$FS_TYPE
tst_mkfs $FS_TYPE $TST_DEVICE
- ROD_SILENT mkdir -p mntpoint
- mount ${TST_DEVICE} mntpoint
- ret=$?
- if [ $ret -ne 0 ]; then
- tst_brk TBROK "failed to mount device (mount exit = $ret)"
- fi
- cd mntpoint
+ tst_mount
+ cd $TST_MOUNT
}
print_ima_config()
--
2.20.1
next prev parent reply other threads:[~2019-02-20 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 16:20 [LTP] [PATCH 1/4] shell: Add tst_mount() helper Petr Vorel
2019-02-20 16:20 ` Petr Vorel [this message]
2019-02-20 16:20 ` [LTP] [PATCH 3/4] shell: Move mkfs.foo into tst_mkfs() Petr Vorel
2019-03-13 14:01 ` Cyril Hrubis
2019-02-20 16:20 ` [LTP] [PATCH 4/4] shell: Use $FS_TYPE and $TST_DEVICE as default params in tst_mkfs() Petr Vorel
2019-03-13 14:03 ` Cyril Hrubis
2019-03-13 15:19 ` Petr Vorel
2019-03-13 13:58 ` [LTP] [PATCH 1/4] shell: Add tst_mount() helper Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220162014.5467-2-pvorel@suse.cz \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox